Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[post-mvp] Figure out how to re-file/re-sign a Filing after it's already been signed #146

Open
jcadam14 opened this issue Apr 8, 2024 · 0 comments

Comments

@jcadam14
Copy link
Contributor

jcadam14 commented Apr 8, 2024

How do we know when a filing needs to be re-signed once changes have been made to an already-signed filing?

Suggestions from Hans:

  • Associate signatures to submissions rather than filings. Then on the signing screen if the submission associated to the filing isn't signed, you now you need to sign it? That wouldn't fix needing to re-sign after changing contact info or institution data, though.

  • Disassociate a signature from a filing if anything changes on a signed filing. Not sure how that'd work in the current one-to-many sigs per filing. Add a invalid/expired type flag?

  • Alternatively, don't have it as a one-to-many, and just hang the signature off the filing record similar to other fields. If anything changes on the filing, the signature gets dropped. We lose history of signature, but makes it simple. If we want history, we could implement it the same way we do for institution data at a later time.

Jason's suggestion:

  • Keeps signatures as is, but if anything else changes (like a new submission, contact info, institution snapshot id), drop the confirmation_id. That way we keep the history of signatures, but the confirmation_id is the thing showing if the current Filing has been signed. When it is re-signed, create a new signature and confirmation id.
@jcadam14 jcadam14 changed the title Figure out how to re-file/re-sign a Filing after it's already been signed [Probably Post-MVP] Figure out how to re-file/re-sign a Filing after it's already been signed Apr 12, 2024
@hkeeler hkeeler changed the title [Probably Post-MVP] Figure out how to re-file/re-sign a Filing after it's already been signed [post-mvp] Figure out how to re-file/re-sign a Filing after it's already been signed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants