Use Gunicorn in the Docker container #8676
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chosak
reviewed
Dec 9, 2024
willbarton
force-pushed
the
gunicorn
branch
2 times, most recently
from
510bc5f to
1633e57
Compare
This serves the Django application and static assets with Gunicorn from the "prod" Docker target container.
Instead of running Apache in our production container, run a separate Apache container that `ProxyPass`es to our Django/Gunicorn container.
This changes moves our Gunicorn dependency to a separate requirements file, and moves container-specific Django configuration to a `DEPLOY_ENVIRONMENT==container` check, and adds a `DEPLOY_ENVIRONMENT` environment variable to the container.
For deployment to servers, we do not set APACHE_USER/APACHE_GROUP. This change sets their default to those expected values, to be overridden only if the variables are set in the environment.
This change limits when Apache will proxy pass to the application to when the CFGOV_APPLICATION_HOST env var is set.
chosak
reviewed
Dec 10, 2024
Co-authored-by: Andy Chosak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our existing prod container for cf.gov ran the application via Apache and mod_wsgi, having to compile a custom version of mod_wsgi to make it work. Except it didn't.
This PR adopts Gunicorn in the prod-like container, and configures a separate Apache container to proxy pass to the python container. It also makes the Apache container available in dev.
Run the dev setup with local settings:
Run the prod setup with production settings:
Checklist