Modify user viewability of CDN Tools #7684
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@csebianlander finally coming around to this. If we want to remove the ability of users to even access the CDN view unless they have permission to trigger a cache clear, there's a little more code we can remove, for example. May I push a commit to this PR that does a bit more cleanup? |
|
@chosak no idea why/how I left this sitting so long without responding to you. You are welcome to push more code to the PR, though obviously it's not the highest priority! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the conditions for the "CDN Tools" sidebar option so that it is only visible for users with the
v1.add_cdnhistorypermission.Changes
IfCDNEnabledMenuItemto check user permissionsHow to test this PR
Because
cdn_is_configured()will always fail on local, you can test that the rest of the conditional is working properly by removing that section ofwagtail_hooks.pyand then testing by logging in as a user who has the permission (e.g. admin) and a new or existing user who does not (e.g. any user within the Edit-only group).