Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of app from v1 #1137

Open
kurtrwall opened this issue Nov 4, 2015 · 12 comments
Open

Change name of app from v1 #1137

kurtrwall opened this issue Nov 4, 2015 · 12 comments

Comments

@kurtrwall
Copy link
Contributor

V1 is inherently a temporary name. The name of our app shouldn't be temporary. The project's name is cfgov and we'll be using the core app to store our "toolset". Any ideas?

@jimmynotjim
Copy link
Contributor

How about just main-site or parent-site?

@kurtrwall
Copy link
Contributor Author

Hyphens kind of make python barf...however, let's say our atomic work is "finished". We might want to make that it's own project by itself, and our v1 or main-site app will be in it's own isolated project. Take a look at cfgov-django's app structure. Our team's work could be encapsulated in that project and then installed as an app into cfgov-django. @rosskarchner I'd like to know your thoughts on this.

@rosskarchner
Copy link
Member

I've been thinking the other way around: we move our legacy Django apps into cfgov-refresh (open sourcing a bunch of them in the process).

My votes would be:

  • "core"
  • merging cfgov/v1 into cfgov/cfgov

@jimmynotjim
Copy link
Contributor

I'm going to vote to not repeat names anywhere in the dir structure, that just makes describing locations to others difficult.

@kurtrwall
Copy link
Contributor Author

I was thinking "core" would house our atomic elements, whereas "v1" would use them. Is it okay to merge app code into the project's folder for settings, urls.py, etc?

@kurtrwall
Copy link
Contributor Author

Does anyone see anything wrong with naming it flapjack?

@Scotchester
Copy link
Contributor

Does anyone see anything wrong with naming it flapjack?

❤️ 💓 😻

@rosskarchner
Copy link
Member

Yeah-- they're just python packages.

other ideas:

cmscore
cmstypes
cms

wagtail calls their own primary package 'wagtailsite' https://github.com/torchbox/wagtail-wagtailsite

@anselmbradford
Copy link
Member

@cfpb/cfgov-backends Is this something we still want open?

@Scotchester
Copy link
Contributor

Is this something we still want open?

YES

@willbarton
Copy link
Member

@Scotchester speaks for me in these matters.

@cwdavies
Copy link
Contributor

@willbarton I vote for changing the name of app from v1 to cms which is an abbreviation for Content Management System

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants