Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta kategorie #114

Open
pionl opened this issue May 26, 2023 · 4 comments
Open

Meta kategorie #114

pionl opened this issue May 26, 2023 · 4 comments

Comments

@pionl
Copy link
Member

pionl commented May 26, 2023

Aktuálně metakategorie se vložili do kategpriích ale pocitově tam nemají co dělat.

Co jsem pochopil, tak to má spojit kategorie a vytvořit "nad kategorii".

Správně má být meta kategorie ve vlastním AirTable seznamu a místo v jsonu categories by to mělo být třeba meta_categories.

Takto se to ohnulo a muselo se přidat filtrace isMetaOnly apod. Další prostor udělat chybu jak v AirTable tak i v kódu.

cc @met @kubito @vchlum

@met
Copy link
Collaborator

met commented May 26, 2023

Přidávám @JuroUhlar který metakategorie řeší.
Juraj to chtěl tenhle víkend doladit, přejmenovat "metacategories" na "subcategories", čímž by to dávalo smysl.

viz vlákno ve Slacku https://cesko-digital.slack.com/archives/C03BYED3ARK/p1684659317880859

@JuroUhlar
Copy link
Collaborator

@pionl Yes it's a mess right now. I proposed renaming the "meta categories" to "subcategories", deleting the "meta_only" boolean, and relying on checking if the category has phrases.length > 0 or subcategories.length > 0 it shouldn't have both.

We could separate meta categories into their own table but @met is counting with multiple nesting levels in the future, so maybe having it all in one table is more flexible. Let me know what you think, open to other ideeas how to structure it. If we agree, I can fix it this weekend.

@pionl
Copy link
Member Author

pionl commented Jun 8, 2023

Depends how dictionary should be shown. If the "subcategories" will not be in dictionary, then it should not be in categories and it should be in separate part. This would make quite a mess in long term and is better to separate it

But, its up on you at this moment :) Both approaches are doable but first approach could be more open to bugs :)

@met
Copy link
Collaborator

met commented Jun 8, 2023

@pionl For now subcategories are not in dictionary. But the idea is in the end to show them in dictionary (still need to figure how we want to do it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants