Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patternal] Note off messages should be sent right before the next beat #52

Open
aalex opened this issue Dec 16, 2024 · 1 comment
Open

[patternal] Note off messages should be sent right before the next beat #52

aalex opened this issue Dec 16, 2024 · 1 comment
Labels
bug Something isn't working question Further information is requested

Comments

@aalex
Copy link
Collaborator

aalex commented Dec 16, 2024 •
edited
Loading

[patternal] Note off messages should be sent right before the next beat, and not immediately after its note on.

This is so that we can hear some MIDI notes for enough time so that the listener can actually hear it.

Technical details

See PR #50
@aalex aalex added bug Something isn't working question Further information is requested labels Dec 16, 2024
@aalex
Copy link
Collaborator Author

aalex commented Dec 17, 2024

The note off should happen on the next beat - not right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aalex