You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In an effort to bootstrap viem migration in a managable way the idea is to migrate CheckBuilder class from packages/cli/src/utils/checks.ts so it uses viem client instead of web3/contract kit.
We should remove both following methods from the class:
The client (ideally WalletClient extended with publicActions) should be injected on demand and created by BaseCommand.
We can also check the coverage for the builder and cover explicitly whatever necessary (right now it's mostly/if not only indirectly tested by other tests).
Check this closed PR for ready code snippets and inspiration.
The text was updated successfully, but these errors were encountered:
must be able to use both viem and ck based commands at same time. because doing all it once would be too big. IE switch one command at a time.
can use most of base code for ViemCommand
stay focused!
keep tests as is!
add public actions to the walletClient on viem instead of separate clients.
make CheckBuilder work with viem. pass client to check builder from command. black box.
In an effort to bootstrap viem migration in a managable way the idea is to migrate
CheckBuilder
class frompackages/cli/src/utils/checks.ts
so it uses viem client instead of web3/contract kit.We should remove both following methods from the class:
The client (ideally
WalletClient
extended withpublicActions
) should be injected on demand and created byBaseCommand
.We can also check the coverage for the builder and cover explicitly whatever necessary (right now it's mostly/if not only indirectly tested by other tests).
Check this closed PR for ready code snippets and inspiration.
The text was updated successfully, but these errors were encountered: