-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing to delegate #110
Comments
Same issue here. Trying to use Wallet Connect to delegate via Celo Teminal for a validator group / validator. |
hmm initial test i was able to delegate (with metamask) so will continue to figure out what causes failures. |
check fallback/ retry is working |
I think the problem is that Celo Mondo didn't know validators can't delegate, or that it doesn't realize that the signer can voting delegate on behalf of accounts |
@aaronmboyd so for my own understanding: you were logged with a validator (group?) account and trying to delegate from that address or you were trying to delegate votes from a "regular" account to a validator (group?) account? |
Trying to delegate votes from a validator group (Celo derivation path) to a standard EOA (which is registered as a delegate). I open Celo Terminal and connect on Celo Mondo using Wallet Connect which appears to correctly form a connection. Then when I continue to the delegate dialog, select the percentage of locked CELO to delegate and click the button to execute the transaction I get the identical error messages in this issue. |
Thanks for the explanation! This is actually not allowed by
we're adding a check for this on UI level and a word of explanation. |
Oh, that's a pain. Why can't groups and validators delegate? Seems like a good way for them to hand off voting duties to a trusted delegate. |
@aaronmboyd one thing they can do is authorize a vote signer althought that also authorizes to vote for validators. @martinvol might be able to answer why that requiment exists |
Ahhh, so the vote signer has to be the one to perform the delegation? I'll try this |
@aaronmboyd I think it won't work as well because this line will first map vote signer to the validator account if I understand it correctly |
Yes you're right. I can see the hard rule there in the Solidity code. Is there a technical reason for this rule? The majority of locked CELO tokens are locked in validator groups, so it seems an odd limitation to put on delegating governance votes. |
the protocol keeps a 1:1 account <> signer relationship, so a validator can not be a signer. Validators and groups can not delegate, even if there's no signer. The protocol actually holds little Celo in the validator and groups (10K * 110 *2, about 3% of the supply ), some have more, but the excess is not locked, so it can be moved to any other address |
Ahh yes of course, I was thinking of the millions that is voted on groups, not what each group actually locks. My use case is that as a validator, I want to be able to vote once, from an EOA rather than having to unlock beneficiary / signer accounts for each group and validator to participate in governance. But looks like that use case isn't supported. |
@aaronmboyd let me see if i get the situation You run a validator group with multiple validators which you all control. they can all vote on governance proposals but cannot delegate celo they own. and it would be easier to be able to delegate, but this is not possible for validators/validator groups. I agree that would be nice. I wonder if one day we might lift the restriction. 🤔 @martinvol would have to answer if that would be safe to do in future HF. |
Probably not worth it now since there will not really be a concept of "validator" going forward |
Description
The text was updated successfully, but these errors were encountered: