Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace existing redundant congestion control mech with reactor specific limitations #1546

Open
evan-forbes opened this issue Dec 4, 2024 · 0 comments
Labels
p2p refactor WS: Big Blonks 🔭 Improving consensus critical gossiping protocols

Comments

@evan-forbes
Copy link
Member

Currently, the p2p relies heavily on a per peer rate limiting the send and receive rate. Peers can send redundant messages or requests, and they are not kicked. Instead, they are free to absorb the entire allocated bandwidth without reprocussion.

This is very problematic, as nodes must keep the allocated bandwidth low, which results in two nodes artificially limiting bandwidth they otherwise could be utilizing.

The more time consuming approach is to visit each and every message that is sent or received, and ensuring that there are appropriate protections in place for that message. In general, this will likely fall into these catagories:

  • stateful protections (protect against redundant or unexpected messages)
  • stateless validation (already completed)
  • rate limits on heavy, non-critical, pull based logic (essentially just blocksync)

To close this issue, we need to add these checks for each message in each reactor. Some new infrastructure might be required for rate limits and redudant message checks.

@evan-forbes evan-forbes added WS: Big Blonks 🔭 Improving consensus critical gossiping protocols p2p refactor labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2p refactor WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Development

No branches or pull requests

1 participant