Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Long-Flag Syntax and Missing Key-Path in txClient #3930

Closed
staheri14 opened this issue Oct 1, 2024 · 2 comments
Closed

Fixing Long-Flag Syntax and Missing Key-Path in txClient #3930

staheri14 opened this issue Oct 1, 2024 · 2 comments
Assignees
Labels
bug Something isn't working testing items that are strictly related to adding or extending test coverage

Comments

@staheri14
Copy link
Collaborator

staheri14 commented Oct 1, 2024

Problem

Due to recent changes in the Dockerfile for txsim, the txClient in the e2e tests fails to run because of incorrect syntax used for long flags and a missing option to specify the key path where the keyring is located.

Acceptance Criteria

Fix the mentioned issue and ensure e2e tests pass with no issue.

@staheri14 staheri14 self-assigned this Oct 1, 2024
@staheri14 staheri14 added the bug Something isn't working label Oct 1, 2024
@staheri14 staheri14 added the testing items that are strictly related to adding or extending test coverage label Oct 1, 2024
@rootulp
Copy link
Collaborator

rootulp commented Nov 27, 2024

Is this still a bug? The test-e2e CI task has been failing for a while but it's not clear to me if it's b/c of this or any of the other issues listed in #4028

@staheri14
Copy link
Collaborator Author

The concerns raised about the txclient in this issue, i.e.,

incorrect syntax used for long flags and a missing option to specify the key path

appear to have been addressed in the main branch. As the issue is no longer relevant, I’m closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants