From 61c220904f3decf4c605fc2cdd412eb205392054 Mon Sep 17 00:00:00 2001 From: womensrights Date: Tue, 12 Mar 2024 18:08:54 +0100 Subject: [PATCH 1/6] Update cip-14.md --- cips/cip-14.md | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/cips/cip-14.md b/cips/cip-14.md index 98d8606..7d7ef6c 100644 --- a/cips/cip-14.md +++ b/cips/cip-14.md @@ -213,7 +213,18 @@ This proposal is backwards-incompatible because it is state-machine breaking. Th ## Test Cases -TBA +The following test cases are available in the [ibc-go e2e repository.](https://github.com/cosmos/ibc-go/tree/main/e2e/tests/interchain_accounts) + +- Registration of an interchain account +- Transfer funds from interchain account to a different account on the same chain using an unordered or ordered channel +- A failed transfer of funds from interchain account to a different account on the same chain due to insufficient funds +- Transfer funds from interchain account to a different account on the same chain after an ordered channel closure +- A transfer of funds from an interchain account to a different account on the same chain using a gov controller +- A transfer of funds from an interchain account to a different account on the same chain using a groups controller +- A transfer of funds from an interchain account to a different account on the same chain using an incentivised IBC packet +- Registration of an interchain account, and transfer of funds from an interchain account to a different account on the same chain through the localhost client, and after reopening a channel +- Query if host functionality is enabled +- Transfer funds from interchain account to a different account after upgrading the channel from ordered to unordered ## Reference Implementation From 235947c0dfcf234839b7ae114c9a35ee0ea738ff Mon Sep 17 00:00:00 2001 From: womensrights Date: Wed, 13 Mar 2024 17:40:50 +0100 Subject: [PATCH 2/6] Update cip-14.md --- cips/cip-14.md | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/cips/cip-14.md b/cips/cip-14.md index 7d7ef6c..a86c2e3 100644 --- a/cips/cip-14.md +++ b/cips/cip-14.md @@ -216,12 +216,13 @@ This proposal is backwards-incompatible because it is state-machine breaking. Th The following test cases are available in the [ibc-go e2e repository.](https://github.com/cosmos/ibc-go/tree/main/e2e/tests/interchain_accounts) - Registration of an interchain account -- Transfer funds from interchain account to a different account on the same chain using an unordered or ordered channel -- A failed transfer of funds from interchain account to a different account on the same chain due to insufficient funds -- Transfer funds from interchain account to a different account on the same chain after an ordered channel closure -- A transfer of funds from an interchain account to a different account on the same chain using a gov controller -- A transfer of funds from an interchain account to a different account on the same chain using a groups controller -- A transfer of funds from an interchain account to a different account on the same chain using an incentivised IBC packet +- Transfer funds from interchain account to a different account on the same chain using an unordered channel +- Transfer funds from interchain account to a different account on the same chain using an ordered channel +- A failed transfer of funds from interchain account to a different account on the same chain due to insufficient funds in the interchain account balance +- Transfer funds from interchain account to a different account on the same chain after an ordered channel closes and a new channel is reopened to connect to the existing interchain account +- A transfer of funds from an interchain account to a different account on the same chain using an x/gov sdk module based controller (on the controlling chain) +- A transfer of funds from an interchain account to a different account on the same chain using a x/group sdk module based controller (on the controlling chain) +- [OPTIONAL] A transfer of funds from an interchain account to a different account on the same chain using an incentivised IBC packet - Registration of an interchain account, and transfer of funds from an interchain account to a different account on the same chain through the localhost client, and after reopening a channel - Query if host functionality is enabled - Transfer funds from interchain account to a different account after upgrading the channel from ordered to unordered From b7832717610bed391b19eec0388d3495c7991db9 Mon Sep 17 00:00:00 2001 From: womensrights Date: Mon, 18 Mar 2024 13:33:43 +0100 Subject: [PATCH 3/6] Update cip-14.md --- cips/cip-14.md | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/cips/cip-14.md b/cips/cip-14.md index a86c2e3..d87944a 100644 --- a/cips/cip-14.md +++ b/cips/cip-14.md @@ -215,17 +215,16 @@ This proposal is backwards-incompatible because it is state-machine breaking. Th The following test cases are available in the [ibc-go e2e repository.](https://github.com/cosmos/ibc-go/tree/main/e2e/tests/interchain_accounts) -- Registration of an interchain account -- Transfer funds from interchain account to a different account on the same chain using an unordered channel -- Transfer funds from interchain account to a different account on the same chain using an ordered channel -- A failed transfer of funds from interchain account to a different account on the same chain due to insufficient funds in the interchain account balance -- Transfer funds from interchain account to a different account on the same chain after an ordered channel closes and a new channel is reopened to connect to the existing interchain account -- A transfer of funds from an interchain account to a different account on the same chain using an x/gov sdk module based controller (on the controlling chain) -- A transfer of funds from an interchain account to a different account on the same chain using a x/group sdk module based controller (on the controlling chain) -- [OPTIONAL] A transfer of funds from an interchain account to a different account on the same chain using an incentivised IBC packet -- Registration of an interchain account, and transfer of funds from an interchain account to a different account on the same chain through the localhost client, and after reopening a channel -- Query if host functionality is enabled -- Transfer funds from interchain account to a different account after upgrading the channel from ordered to unordered +- Registration of an interchain account - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/base_test.go#L46) +- Transfer funds from interchain account to a different account on the same chain using an unordered channel - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/base_test.go#L56) +- Transfer funds from interchain account to a different account on the same chain using an ordered channel - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/base_test.go#L52) +- A failed transfer of funds from interchain account to a different account on the same chain due to insufficient funds in the interchain account balance - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/base_test.go#L159) +- Transfer funds from interchain account to a different account on the same chain after an ordered channel closes and a new channel is reopened to connect to the existing interchain account - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/base_test.go#L249) +- A transfer of funds from an interchain account to a different account on the same chain using an x/gov sdk module based controller (on the controlling chain) - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/gov_test.go) +- A transfer of funds from an interchain account to a different account on the same chain using a x/group sdk module based controller (on the controlling chain) - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/groups_test.go) +- [OPTIONAL] A transfer of funds from an interchain account to a different account on the same chain using an incentivised IBC packet - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/incentivized_test.go#L38) +- Query if host functionality is enabled - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/params_test.go#L106) +- Transfer funds from interchain account to a different account after upgrading the channel from ordered to unordered - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/upgrades_test.go#L41) ## Reference Implementation From 92d506a8193c054699ba6852fceb6d2f4327fb59 Mon Sep 17 00:00:00 2001 From: Susannah Evans <65018876+womensrights@users.noreply.github.com> Date: Tue, 19 Mar 2024 11:36:48 +0100 Subject: [PATCH 4/6] Update cips/cip-14.md Co-authored-by: Rootul P --- cips/cip-14.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cips/cip-14.md b/cips/cip-14.md index d87944a..12e8eaa 100644 --- a/cips/cip-14.md +++ b/cips/cip-14.md @@ -216,7 +216,7 @@ This proposal is backwards-incompatible because it is state-machine breaking. Th The following test cases are available in the [ibc-go e2e repository.](https://github.com/cosmos/ibc-go/tree/main/e2e/tests/interchain_accounts) - Registration of an interchain account - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/base_test.go#L46) -- Transfer funds from interchain account to a different account on the same chain using an unordered channel - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/base_test.go#L56) +- [OPTIONAL] Transfer funds from interchain account to a different account on the same chain using an unordered channel - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/base_test.go#L56). Note: requires ibc-go >= v8.1.0. - Transfer funds from interchain account to a different account on the same chain using an ordered channel - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/base_test.go#L52) - A failed transfer of funds from interchain account to a different account on the same chain due to insufficient funds in the interchain account balance - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/base_test.go#L159) - Transfer funds from interchain account to a different account on the same chain after an ordered channel closes and a new channel is reopened to connect to the existing interchain account - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/base_test.go#L249) From 818e030e26a9a6d2731a55cc432c2f580efaee37 Mon Sep 17 00:00:00 2001 From: Susannah Evans <65018876+womensrights@users.noreply.github.com> Date: Tue, 19 Mar 2024 11:36:58 +0100 Subject: [PATCH 5/6] Update cips/cip-14.md Co-authored-by: Rootul P --- cips/cip-14.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cips/cip-14.md b/cips/cip-14.md index 12e8eaa..b11c5c7 100644 --- a/cips/cip-14.md +++ b/cips/cip-14.md @@ -222,7 +222,7 @@ The following test cases are available in the [ibc-go e2e repository.](https://g - Transfer funds from interchain account to a different account on the same chain after an ordered channel closes and a new channel is reopened to connect to the existing interchain account - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/base_test.go#L249) - A transfer of funds from an interchain account to a different account on the same chain using an x/gov sdk module based controller (on the controlling chain) - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/gov_test.go) - A transfer of funds from an interchain account to a different account on the same chain using a x/group sdk module based controller (on the controlling chain) - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/groups_test.go) -- [OPTIONAL] A transfer of funds from an interchain account to a different account on the same chain using an incentivised IBC packet - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/incentivized_test.go#L38) +- [OPTIONAL] A transfer of funds from an interchain account to a different account on the same chain using an incentivised IBC packet - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/incentivized_test.go#L38). Note: requires relayer incentivization middleware. - Query if host functionality is enabled - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/params_test.go#L106) - Transfer funds from interchain account to a different account after upgrading the channel from ordered to unordered - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/upgrades_test.go#L41) From 24333ad223c90f006afeb6c795fc5a23dc7ca1c5 Mon Sep 17 00:00:00 2001 From: Susannah Evans <65018876+womensrights@users.noreply.github.com> Date: Tue, 19 Mar 2024 11:37:12 +0100 Subject: [PATCH 6/6] Update cips/cip-14.md Co-authored-by: Rootul P --- cips/cip-14.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cips/cip-14.md b/cips/cip-14.md index b11c5c7..96a755f 100644 --- a/cips/cip-14.md +++ b/cips/cip-14.md @@ -224,7 +224,7 @@ The following test cases are available in the [ibc-go e2e repository.](https://g - A transfer of funds from an interchain account to a different account on the same chain using a x/group sdk module based controller (on the controlling chain) - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/groups_test.go) - [OPTIONAL] A transfer of funds from an interchain account to a different account on the same chain using an incentivised IBC packet - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/incentivized_test.go#L38). Note: requires relayer incentivization middleware. - Query if host functionality is enabled - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/params_test.go#L106) -- Transfer funds from interchain account to a different account after upgrading the channel from ordered to unordered - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/upgrades_test.go#L41) +- [OPTIONAL] Transfer funds from interchain account to a different account after upgrading the channel from ordered to unordered - [test link](https://github.com/cosmos/ibc-go/blob/main/e2e/tests/interchain_accounts/upgrades_test.go#L41). Note: requires ibc-go >= v8.1.0. ## Reference Implementation