From 14f513cc7a115de47ce58f748d0131c880bfdb54 Mon Sep 17 00:00:00 2001 From: Wondertan Date: Wed, 27 Mar 2024 20:52:15 +0100 Subject: [PATCH] cip-19: adressing review comments from @rootulp --- cips/cip-19.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/cips/cip-19.md b/cips/cip-19.md index 89a248df..4dc96c8e 100644 --- a/cips/cip-19.md +++ b/cips/cip-19.md @@ -152,8 +152,8 @@ The fields with validity rules that form EdsID are: #### Eds Container -Eds containers encapsulate the [DataSquare][square]. Internally, they only keep the original data(1st quadrant) of the -EDS with redundant data(2nd, 3rd and 4th quadrants) computable from the original data. +Eds containers encapsulate the [DataSquare][square]. Internally, they only keep the original data (1st quadrant) of the +EDS with redundant data (2nd, 3rd and 4th quadrants) computable from the original data. Eds containers MUST be formatted by serializing ODS left-to-right share-by-share in the row-major order. @@ -184,8 +184,8 @@ It MUST not exceed the number of [DAH][dah] Row roots reduced by one. #### Row Container -Row containers encapsulate the rows of the [DataSquare][square]. Internally, they only keep the left(original) half of -the row with right(redundant) half recomputable from the left half. +Row containers encapsulate the rows of the [DataSquare][square]. Internally, they only keep the left (original) half of +the row with right (redundant) half recomputable from the left half. Row containers are protobuf formatted using the following proto3 schema: @@ -372,7 +372,7 @@ should be extended whenever any new share identifier or new version of an existi | DataID | 0x7821 | 0x7820 | *EdsID and container are excluded from Bitswap composition. Bitswap is limited to messages of size 256kb, while EDSes are -expected to be bigger. Also, its more efficient to parallelize EDS requesting by rows. +expected to be bigger. Also, it is more efficient to parallelize EDS requesting by rows. ## Backwards Compatibility