Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Resource Extractor API_LOOKUP share method not finding aws-sdk #80

Open
maafk opened this issue Nov 2, 2022 · 1 comment · Fixed by #81
Open

bug: Resource Extractor API_LOOKUP share method not finding aws-sdk #80

maafk opened this issue Nov 2, 2022 · 1 comment · Fixed by #81
Labels
bug Something isn't working

Comments

@maafk
Copy link
Contributor

maafk commented Nov 2, 2022

What is the problem?

The API_LOOKUP method for sharing values not currently functioning

Reproduction Steps

Using the ResourceExtractor with API_LOOKUP

cdk.Aspects.of(app).add(ResourceExtractor(
    extract_destination_stack=extracted_stack,
    resource_types_to_extract=[
        "AWS::IAM::Role",
        "AWS::IAM::Policy",
        "AWS::IAM::ManagedPolicy",
        "AWS::IAM::InstanceProfile",
    ],
    stack_artifacts=synthed_app.stacks,
    value_share_method=ResourceExtractorShareMethod.API_LOOKUP
))

The API lookup doesn't take place, resulting in the dummy-value-for-* being left in the synthesized cloudformation

What did you expect to happen?

Expected the resolved API lookup to be injected

What actually happened?

The API lookup doesn't take place, resulting in the dummy-value-for-* being left in the synthesized cloudformation

cdk-enterprise-iac version

0.0.62

Language

Typescript, Python

Other information

No response
@maafk maafk added the bug Something isn't working label Nov 2, 2022
@maafk maafk mentioned this issue Nov 2, 2022
Merged
@mergify mergify bot closed this as completed in #81 Nov 2, 2022
mergify bot pushed a commit that referenced this issue Nov 2, 2022
@maafk
fix: Adjust README to fix typo and explain that API_LOOKUP is in prog…
2b8fdb7 
…ress (#81)

Fixes #80
@maafk maafk reopened this Nov 2, 2022
@maafk
Copy link
Contributor Author

maafk commented Nov 2, 2022

Previous PR only updated docs to inform this isn't working yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Adjust README to fix typo and explain that API_LOOKUP is in progress cdklabs/cdk-enterprise-iac
1 participant
@maafk