Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outdated libraries, broken functions, unused variables #32

Open
GGrosskreutz opened this issue Mar 19, 2022 · 0 comments
Open

outdated libraries, broken functions, unused variables #32

GGrosskreutz opened this issue Mar 19, 2022 · 0 comments

Comments

@GGrosskreutz
Copy link

on the website which makes reference to this repo ('https://towardsdatascience.com/making-a-i-that-looks-into-trade-charts-62e7d51edcba')

function "convolve_sma" is called but not defined
mpl_finance cannot call candlestick2_ochl anymore, mplfinance.original_flavor.candlestick2_ochl seems to work
call time.time() but time isnt imported
realtime_data variable is called but never referenced

you could eliminate like 12 or more lines of code and make things a bit easier to understand with a similar file naming convention

broken tutorials are a huge source of frustration mostly on the new programmers.
every part of this tutorial has similar problems
surely the crypto affiliate is enough incentive to maintain your article/repo, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant