[bondhome] remove internal binding version

OpenHAB already has infrastructure to have things update their
channel definitions when a binding is updated.

Signed-off-by: Cody Cutrer <[email protected]>

Author: ccutrer

bundles/org.openhab.binding.bondhome/src/main/java/org/openhab/binding/bondhome/internal/BondHomeBindingConstants.java

@@ -30,7 +30,6 @@
 public class BondHomeBindingConstants {
 
     public static final String BINDING_ID = "bondhome";
-    public static final String CURRENT_BINDING_VERSION = "v0.2.4";
 
     /**
      * List of all Thing Type UIDs.
@@ -110,7 +109,6 @@ public class BondHomeBindingConstants {
     public static final String PROPERTIES_TRUST_STATE = "trustState";
     public static final String PROPERTIES_ADDRESS = "addr";
     public static final String PROPERTIES_RF_FREQUENCY = "freq";
-    public static final String PROPERTIES_BINDING_VERSION = "bindingVersion";
 
     /**
      * Constants

bundles/org.openhab.binding.bondhome/src/main/java/org/openhab/binding/bondhome/internal/handler/BondDeviceHandler.java

@@ -516,7 +516,7 @@ private void initializeThing() {
         // Anytime the configuration has changed or the binding has been updated,
         // recreate the thing to make sure all possible channels are available
         // NOTE: This will cause the thing to be disposed and re-initialized
-        if (wasBindingUpdated() || wasThingUpdatedExternally(devInfo)) {
+        if (wasThingUpdatedExternally(devInfo)) {
             recreateAllChannels(devInfo.type, devInfo.hash);
             return;
         }
@@ -536,7 +536,6 @@ private void initializeThing() {
     private void updateDevicePropertiesFromBond(BondDevice devInfo, BondDeviceProperties devProperties) {
         // Update all the thing properties based on the result
         Map<String, String> thingProperties = new HashMap<String, String>();
-        thingProperties.put(PROPERTIES_BINDING_VERSION, CURRENT_BINDING_VERSION);
         thingProperties.put(CONFIG_DEVICE_ID, config.deviceId);
         logger.trace("Updating device name to {}", devInfo.name);
         thingProperties.put(PROPERTIES_DEVICE_NAME, devInfo.name);
@@ -697,25 +696,6 @@ private boolean hasConfigurationError() {
                 && statusInfo.getStatusDetail() == ThingStatusDetail.CONFIGURATION_ERROR || disposed;
     }
 
-    private synchronized boolean wasBindingUpdated() {
-        // Check if the binding has been updated
-        @Nullable
-        String lastBindingVersion = this.getThing().getProperties().get(PROPERTIES_BINDING_VERSION);
-        if (CURRENT_BINDING_VERSION.equals(lastBindingVersion)) {
-            return false;
-        }
-
-        logger.debug("Bond Home binding has been updated.");
-        logger.debug("Current version is {}, prior version was {}.", CURRENT_BINDING_VERSION, lastBindingVersion);
-
-        // Update the thing with the new property value
-        final Map<String, String> newProperties = editProperties();
-        newProperties.put(PROPERTIES_BINDING_VERSION, CURRENT_BINDING_VERSION);
-
-        updateProperties(newProperties);
-        return true;
-    }
-
     private synchronized boolean wasThingUpdatedExternally(BondDevice devInfo) {
         // Check if the Bond hash tree has changed
         final String lastDeviceConfigurationHash = config.lastDeviceConfigurationHash;