Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad rendering of (some) diacritics/Unicode in game description #150

Open
Kaligula0 opened this issue Jun 1, 2020 · 5 comments
Open

bad rendering of (some) diacritics/Unicode in game description #150

Kaligula0 opened this issue Jun 1, 2020 · 5 comments

Comments

@Kaligula0
Copy link
Contributor

https://www.boardgamegeek.com/boardgame/33458/carcassonne-expansion-6-count-king-robber should have "by Hans im Glück" but renders "by Hans im Glück".
Screenshot_20200531-145233

Also https://www.boardgamegeek.com/boardgame/18836/Carcassonne-river-II should have "contained in Carcassonne: Expansion 6 – Count, King & Robber" but renders "contained in Carcassonne: Expansion 6 – Count, King & Robber".
Screenshot_20200601-124845

@ccomeaux
Copy link
Owner

ccomeaux commented Jun 4, 2020

This is a bug in the BGG API. In the first example you show, it's returning ü instead of ü. I believe this is due to double encoding. I've tried to reverse this, but I haven't been able to find a way.

@Kaligula0
Copy link
Contributor Author

@virre
Copy link

virre commented Jun 12, 2020

As I wrote on the above bugreport, it is possible that BGG have added BOMS to the XML response and if I see correctly you use JAVA that can't handle UTF-8 strings with BOM. (JAVA is not a language I am knowledgeable about as I have hardly touched it after 2000, but google seems to sugest this)

@Kaligula0
Copy link
Contributor Author

API v1 returns properly encoded characters. API v2 has bugs.

@Kaligula0
Copy link
Contributor Author

Kaligula0 commented Feb 16, 2023

Can we move to API v1 then?
(with getting the description)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants