You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
getCultureLevelInfo and getNumCultureLevelInfos count all culture levels from the xml, not caring whether the realistic culture gameoption is on or not. As a result, there are multiple places in the dll that check this inconsistently. For example
Going from "Developing" to "Refined" in a standard game (skipping over Prominent) causes borders to grow twice, because level has grown by 2. Similar effects are likely all over.
A proper fix should probably involve fixing the two base functions to appropriately count levels and get info, only for levels that are applicable due to game options. Flabbert has said:
"this is the time you create a new class that holds the culture calculations, create a new calculator there, and call that everywhere
you can even make it static"
Sadly, I have concluded I don't understand well enough to do myself 😓
The text was updated successfully, but these errors were encountered:
getCultureLevelInfo
andgetNumCultureLevelInfos
count all culture levels from the xml, not caring whether the realistic culture gameoption is on or not. As a result, there are multiple places in the dll that check this inconsistently. For exampleGoing from "Developing" to "Refined" in a standard game (skipping over Prominent) causes borders to grow twice, because level has grown by 2. Similar effects are likely all over.
Example workaround for updateCultureLevel:
Bad fix on realistic-culture-tweaks branch, will need removal if done properly!
A proper fix should probably involve fixing the two base functions to appropriately count levels and get info, only for levels that are applicable due to game options. Flabbert has said:
"this is the time you create a new class that holds the culture calculations, create a new calculator there, and call that everywhere
you can even make it static"
Sadly, I have concluded I don't understand well enough to do myself 😓
The text was updated successfully, but these errors were encountered: