Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CultureLevelInfo xml isn't parsed properly #1394

Open
dzfischer opened this issue Aug 21, 2022 · 1 comment · Fixed by #1397
Open

CultureLevelInfo xml isn't parsed properly #1394

dzfischer opened this issue Aug 21, 2022 · 1 comment · Fixed by #1397
Assignees
Labels
bug Something isn't working dll A C++ issue

Comments

@dzfischer
Copy link
Contributor

getCultureLevelInfo and getNumCultureLevelInfos count all culture levels from the xml, not caring whether the realistic culture gameoption is on or not. As a result, there are multiple places in the dll that check this inconsistently. For example
Going from "Developing" to "Refined" in a standard game (skipping over Prominent) causes borders to grow twice, because level has grown by 2. Similar effects are likely all over.

Example workaround for updateCultureLevel:
Bad fix on realistic-culture-tweaks branch, will need removal if done properly!

A proper fix should probably involve fixing the two base functions to appropriately count levels and get info, only for levels that are applicable due to game options. Flabbert has said:
"this is the time you create a new class that holds the culture calculations, create a new calculator there, and call that everywhere
you can even make it static"

Sadly, I have concluded I don't understand well enough to do myself 😓

@dzfischer dzfischer added bug Something isn't working dll A C++ issue labels Aug 21, 2022
@MattOttawa MattOttawa self-assigned this Aug 22, 2022
@dzfischer
Copy link
Contributor Author

Hm, didn't mean to make this autoclose.
Last commit to #1400 had a workaround, but base issue is still present and causing issues I'm sure.

@dzfischer dzfischer reopened this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dll A C++ issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants