Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session_server configuration #243

Conversation

kayman-mk
Copy link
Collaborator

@kayman-mk kayman-mk commented Jul 27, 2020

Description

This feature allows you to open an interactive web terminal an run one-off commands in your CI pipeline. See Interactive Web Terminals.

The connection can be established via an EIP (enable_eip) or via an ALB (session_server_listener_arn). The EIP part was already implemented. This PR adds the logic for the ALB.

Migrations required

NO

Verification

Deployed this version of the module in the Hapag-Lloyd development system and ran some jobs against it. Verified that it is possible to open the Web Terminal using EIP and ALB.

Documentation

Root README.md updated.

Closes #92

@kayman-mk kayman-mk changed the title Merge branch 'release/4.19.0' Add session_server configuration Jul 27, 2020
@kayman-mk
Copy link
Collaborator Author

@npalm Still an ongoing PR. I am running out of time at the moment. My guess is, that it is already complete. But the final check is still missing.

@kayman-mk
Copy link
Collaborator Author

Hi @npalm, any chance to test this PR? I tried it today but it seems that I do not have access to all ports of an EC2 instance in our cloud.
What I have seen so far: The runner is started (and processes incoming jobs) and Gitlab shows the "Debug" button next to "Retry/Cancel". But when I open the web terminal via "Debug" it reports "Connection failed". I guess it is due to blocked ports. Any chance to verify that?

You have to add the following parameters to the configuration.

enable_eip = true

  session_server = {
    timeout = 900,
    port = 8093,
    listen_address = "0.0.0.0",
    advertise_address = "<public eip of the agent>",
    listener_arn = "",
    alb_security_group_id = "",
    incoming_cidr_blocks = ["0.0.0.0/0"]
  }

Best regards
Matthias

@npalm
Copy link
Collaborator

npalm commented Nov 21, 2020

@kayman-mk I will do my best to test the PR in the coming days. Since it is still in draft I did not looked at it.. Also one of the CI tasks is failing.

@kayman-mk
Copy link
Collaborator Author

Thanks, Niek. The failing task is the source formatting.

@strowi
Copy link

strowi commented May 27, 2021

hi,

any update on this?

@kayman-mk
Copy link
Collaborator Author

Nice feature, but not needed at the moment on our side. Looks like the PR is too old to simply finish it.

@kayman-mk kayman-mk closed this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for session_server
3 participants