-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add session_server configuration #243
Add session_server configuration #243
Conversation
…upport-for-session-server
…r into kayman-mk/92-add-support-for-session-server
…port-for-session-server
@npalm Still an ongoing PR. I am running out of time at the moment. My guess is, that it is already complete. But the final check is still missing. |
…r into kayman-mk/92-add-support-for-session-server
… into kayman-mk/92-add-support-for-session-server
Hi @npalm, any chance to test this PR? I tried it today but it seems that I do not have access to all ports of an EC2 instance in our cloud. You have to add the following parameters to the configuration.
Best regards |
@kayman-mk I will do my best to test the PR in the coming days. Since it is still in draft I did not looked at it.. Also one of the CI tasks is failing. |
Thanks, Niek. The failing task is the source formatting. |
hi, any update on this? |
Nice feature, but not needed at the moment on our side. Looks like the PR is too old to simply finish it. |
Description
This feature allows you to open an interactive web terminal an run one-off commands in your CI pipeline. See Interactive Web Terminals.
The connection can be established via an EIP (enable_eip) or via an ALB (session_server_listener_arn). The EIP part was already implemented. This PR adds the logic for the ALB.
Migrations required
NO
Verification
Deployed this version of the module in the Hapag-Lloyd development system and ran some jobs against it. Verified that it is possible to open the Web Terminal using EIP and ALB.
Documentation
Root README.md updated.
Closes #92