Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing overmap id's to map_extras #5736

Open
thedyze opened this issue Nov 18, 2024 · 6 comments
Open

Add missing overmap id's to map_extras #5736

thedyze opened this issue Nov 18, 2024 · 6 comments
Labels
enhancement src changes related to source code.

Comments

@thedyze
Copy link
Contributor

thedyze commented Nov 18, 2024

Is your feature request related to a problem? Please describe.

Working on getting rid of missing sprites from the overmap. Many if not all map_extras seem to be missing an overmap id.
The following is stuff I've spotted (probably there's more):

  • dead scientists, drugdeal, military corpses
  • derelict shed
  • grove,
  • portal,
  • dead vegetation,
  • roadworks
  • road block,
  • wasp nest,
  • clay deposit
  • shrubbery,
  • lost campers,
  • road mayhem
  • crater (exists one multi tiled crater type for which there are overmap id, but not the regular small ones)

Describe the solution you'd like

Add overmap id:s to these, would be much appreciated.

Additional context

No response

@chaosvolt
Copy link
Member

Uh. Is that even supported by the code? Map extras are something completely different from overmap terrain.

@thedyze
Copy link
Contributor Author

thedyze commented Nov 18, 2024

Uh. Is that even supported by the code? Map extras are something completely different from overmap terrain.

No idea, was just dreaming XD

@thedyze
Copy link
Contributor Author

thedyze commented Nov 19, 2024

So it was all a pipe dream, I guess this can just be closed?

@chaosvolt
Copy link
Member

I mean, figuring out some way to add tile support to map extra autonotes would be good, I just have no idea how it'd work code wise...

@RoyalFox2140 RoyalFox2140 added the src changes related to source code. label Nov 20, 2024
@RoyalFox2140
Copy link
Collaborator

Map Extras could use sprite support. They all use ascii characters.

@chaosvolt
Copy link
Member

That is literally what the issue is about yes, map extra autonotes don't have anything attached to them code-wise that could be given a sprite specifically because as far as the game is concerned it's just a letter and color pre-selected for a map note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement src changes related to source code.
Projects
None yet
Development

No branches or pull requests

3 participants