Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent plugin from entering shuffling round when it has insufficient funds #10

Open
checksum0 opened this issue Dec 13, 2017 · 2 comments

Comments

@checksum0
Copy link

Currently, the plugin will try to enter a shuffle if a shuffler has unconfirmed outputs to shuffle, resulting in a insufficient fund blame. Make sure plugin behavior prevent this from doing so.

Exception in thread Thread-67:
Traceback (most recent call last):
File "C:\Users\iande\AppData\Local\Programs\Python\Python36-32\lib\threading.py", line 916, in _bootstrap_inner
self.run()
File "C:\Users\iande\AppData\Local\Programs\Python\Python36-32\lib\threading.py", line 864, in run
self._target(*self._args, **self._kwargs)
File "D:\fresh\Electron Cash-3.0\plugins\shuffle\coin_shuffle.py", line 206, in protocol_definition
self.blame_insufficient_funds()
File "D:\fresh\Electron Cash-3.0\plugins\shuffle\coin_shuffle.py", line 121, in blame_insufficient_funds
raise BlameException('Insufficient funds')
electroncash_plugins.shuffle.coin_shuffle.BlameException: Insufficient funds

@clifordsymack
Copy link
Collaborator

This exception arise when some player from pool have unsufficient funds. Shuffle button will not be enbled if player have insufficient fund, but you can't check other players funds before protocol started

@checksum0 checksum0 changed the title Prevent plugin from entering shuffling round when it has insufficient round Prevent plugin from entering shuffling round when it has insufficient funds Dec 14, 2017
@checksum0
Copy link
Author

I agree, but this arose from somebody using the plugin with unconfirmed funds, so leading to the round failing. I agree the server can't check it but the plugin should prevent the users from entering the round if their funds is unconfirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants