Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-connect-go has moved #364

Open
stillmatic opened this issue Aug 3, 2023 · 2 comments
Open

protoc-gen-connect-go has moved #364

stillmatic opened this issue Aug 3, 2023 · 2 comments

Comments

@stillmatic
Copy link
Collaborator

see https://github.com/connectrpc/connect-go/releases/tag/v1.11.0

One path to support would be just to update the org

However, the code doesn't appear to be backwards incompatible

cannot use greeter (variable of type *GreetServer) as ballonv1connect.BalloonServiceHandler value in argument to ballonv1connect.NewBalloonServiceHandler: *GreetServer does not implement ballonv1connect.BalloonServiceHandler (wrong type for method Greet)
		have Greet(context.Context, *"connectrpc.com/connect".Request[ballonv1.GreetRequest]) (*"connectrpc.com/connect".Response[ballonv1.GreetResponse], error)
		want Greet(context.Context, *"github.com/bufbuild/connect-go".Request[ballonv1.GreetRequest]) (*"github.com/bufbuild/connect-go".Response[ballonv1.GreetResponse], error)compiler[InvalidIfaceAssign](https://pkg.go.dev/golang.org/x/tools/internal/typesinternal#InvalidIfaceAssign)

which is super fun to fix...

@alecthomas
Copy link
Collaborator

I don't think this should effect any current tooling or libraries right? The old code is still present AFAICT, and we build our own binaries for this.

@stillmatic
Copy link
Collaborator Author

it won't affect any current tooling - but it will keep those tools pinned on an older version of connect. the issue lies with supporting new versions of connect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants