coreEnforcer.buildRoleLinksInternal calls model.buildRoleLinks(rmMap) on values of rmMap

[richard-sim]

node-casbin/src/coreEnforcer.ts

Line 367 in f859d10

await this.model.buildRoleLinks(this.rmMap);

Due to a refactor ~6 months ago, model.buildRoleLinks(rmMap) is called within a loop over rmMap.values() in coreEnforcer.buildRoleLinksInternal(). Not only is this inefficient, but if rmMap is empty then model.buildRoleLinks() will never be called.

[casbin-bot]

@Gabriel-403 @Zxilly @kingiw @nodece

[Shivansh-yadav13]

@richard-sim do you have any suggestions on how it can be improved?

[hsluoyz]

@fabian4 @nodece

[richard-sim]

@Shivansh-yadav13: It's been a while since I opened this issue, but IIRC it should not be in the loop at all (as it was prior to the refactor that I referred to).

[Shivansh-yadav13]

Not only is this inefficient, but if rmMap is empty then model.buildRoleLinks() will never be called.

but we will have Default Role Manager? if we use role definition in the model