Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if and how we can extract the integration tests into suites #140

Closed
3 tasks done
carlspring opened this issue Dec 14, 2020 · 2 comments · Fixed by #155
Closed
3 tasks done

Investigate if and how we can extract the integration tests into suites #140

carlspring opened this issue Dec 14, 2020 · 2 comments · Fixed by #155
Assignees
Labels
help wanted Extra attention is needed
Milestone

Comments

@carlspring
Copy link
Owner

carlspring commented Dec 14, 2020

Task Description

At the moment, the integration tests are executed as separate tests using the maven-failsafe-plugin. We need to re-work this so that they are executed as a suite. This needs to be done so that we could be able to re-run the same integration tests against different environments. For example, the default profile for integration tests should be against a real Amazon S3. However, if we re-work these to be executed as a suite, we could then add another suite with the same tests, but for MinIO instead.

What we can do is:

  • Have all the integration tests that are connecting to S3 tagged using the @Tag("integration-test-s3") annotation.
  • Create separate test suites that have an @IncludeTags("integration-test-s3") annotation
  • Create an AmazonS3ITTestSuite.
  • Eventually, create additional test suites such as, for example, MinIOITTestSuite.
  • Make the maven-failsafe-plugin only execute the *ITSuite classes.

Tasks

The following tasks will need to be carried out:

  • Investigate whether it's possible to enable/trigger profiles for JUnit tests at a suite level.
  • Create a test suite for all the integration tests.
  • Make the maven-failsafe-plugin only execute *ITSuite-s.

Task Relationships

This task:

Stackoverflow Questions

Help

@carlspring
Copy link
Owner Author

We'll have to re-visit this topic once junit-team/junit5#744 (supposed to be fixed via junit-team/junit5#2416) have been impemented, so that we could drop the JUnit4 dependencies.

@carlspring
Copy link
Owner Author

Eventually, when #60 and #103 have been implemented, we'll create a new suite for MinIO.

@carlspring carlspring self-assigned this Dec 22, 2020
@carlspring carlspring mentioned this issue Jan 23, 2021
7 tasks
@carlspring carlspring added this to the 1.0.0 milestone Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
1 participant