Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remaining balanceTx unit and property tests to Conway #4882

Open
Anviking opened this issue Dec 12, 2024 · 1 comment
Open

Update remaining balanceTx unit and property tests to Conway #4882

Anviking opened this issue Dec 12, 2024 · 1 comment
Assignees
Labels
ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG

Comments

@Anviking
Copy link
Member

Anviking commented Dec 12, 2024

Why?

The cardano-balance-tx:test test suite, in particular Internal.Cardano.Write.Tx.BalanceSpec has several tests only running in the Babbage era, and not in Conway. The main balanceTx property is already running in both eras, but there are other tests which aren't.

For continued confidence when supporting new node bumps and future eras, these tests should be updated to use Conway. Ideally, they should automatically be run in all recent eras, such that we cannot forget to update them when a new era is introduced.

The https://cardanofoundation.atlassian.net/browse/ADP-3413 e2e test failure showed that coverage in both unit and integration tests were lacking in the context of balancing plutus txs in Conway.

What?

All Internal.Cardano.Write.Tx.BalanceSpec tests should run in either Conway or Conway and Babbage.

How?

No response

@Anviking Anviking added IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG labels Dec 12, 2024
@Anviking
Copy link
Member Author

Draft PR: #4762

@Anviking Anviking self-assigned this Dec 12, 2024
@Anviking Anviking changed the title Update balanceTx unit and property tests to Conway Update remaining balanceTx unit and property tests to Conway Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Development

No branches or pull requests

1 participant