More testing of withListeningSocket #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
added
the
RESOLVING ISSUE
With the binary from #2064 (and master I suspect) it failed, but with this fix, it passes for me. |
|
Or the fix still failed when I retried a few times. |
rvl
force-pushed
the
rvl/2067/fix-windows-tests
branch
from
5daa76a to
c5dac1d
Compare
rvl
changed the title
|
Turns out my theory about there being a race against withListeningSocket was wrong. |
|
These tests are pretty old and were working fine for long. Yet I recently updated them when we bumped to version of the tls package to include support for TLS 1.2+. So there could be some windows specific thing regarding TLS 1.2 🤔 ? |
rvl
force-pushed
the
rvl/2067/fix-windows-tests
branch
from
c5dac1d to
551f0ce
Compare
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
This might fix #2067.
Overview
I initially had a theory that the function
withListeningSocketonly bound the socket, but did not start listening. Therefore, connections to the port which were made during thewithListeningSocketaction, but before the warp server starts listening, would be refused. However this was incorrect.This PR adds another test case to check that the socket really is listening.
Comments