-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed tag token colors #18265
base: main
Are you sure you want to change the base?
Fixed tag token colors #18265
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18265 +/- ##
=======================================
Coverage 84.31% 84.31%
=======================================
Files 404 404
Lines 14359 14359
Branches 4606 4606
=======================================
Hits 12107 12107
Misses 2090 2090
Partials 162 162 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
Closes #18264
The
cds--definition-term
class was styling the label color. Now, we ensure the correct style is applied to the label by targeting it directly.Changelog
Testing / Reviewing