Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@carbon/ibmdotcom-styles]: remove React classes from component styles #11194

Open
44 tasks
Tracked by #11191
kennylam opened this issue Dec 5, 2023 · 3 comments · May be fixed by #11218
Open
44 tasks
Tracked by #11191

[@carbon/ibmdotcom-styles]: remove React classes from component styles #11194

kennylam opened this issue Dec 5, 2023 · 3 comments · May be fixed by #11218
Assignees
@sangeethababu9223
Labels
package: styles Work necessary for the Carbon for IBM.com styles package package: web components Work necessary for the IBM.com Library web components package

Comments

@kennylam
Copy link
Member

kennylam commented Dec 5, 2023 •
edited by sangeethababu9223
Loading

Currently all component stylesheets still have a large amount of React-specific styles. These need to be removed. Items in the tasklist should be converted to issues as they are assigned. Net-new components created as web components have been excluded.

Components
Beta Give feedback
  1. button group #11198
    package: styles package: web components
    andy-blum
  2. button #11219
    andy-blum
  40. masthead #11263
@kennylam kennylam mentioned this issue Dec 5, 2023
Open
@kennylam kennylam added package: styles Work necessary for the Carbon for IBM.com styles package package: web components Work necessary for the IBM.com Library web components package labels Dec 5, 2023
@kennylam kennylam moved this to Backlog in Carbon for IBM.com Dec 5, 2023
@kennylam kennylam changed the title [web-components]: remove React classes from component styles [@carbon/ibmdotcom-styles]: remove React classes from component styles Dec 5, 2023
@sangeethababu9223 sangeethababu9223 self-assigned this Dec 6, 2023
@sangeethababu9223 sangeethababu9223 moved this from Backlog to Doing in Carbon for IBM.com Dec 6, 2023
@sangeethababu9223 sangeethababu9223 linked a pull request Dec 12, 2023 that will close this issue
Open
@m4olivei
Copy link
Contributor

Hey @sangeethababu9223 👋 . I see you've opened a PR, is your intent to cover off all of the components in the list there? My impression per the issue description here was that there would be a PR per component, and each component in the list assigned individually. I have space to take on a few components, but I don't want to duplicate work. Let us know how we can work in tandem. Thanks!

@sangeethababu9223
Copy link
Member

sangeethababu9223 commented Dec 15, 2023 •
edited
Loading

Hi @m4olivei,
I had created the PR with the intent to include changes to all the components in the PR itself.
I'm afraid I am almost done with all of them - some of the components didn't need any change in the style so I've left those as it was.

Thanks for pointing out the need for separate PRs, I'd check on that make the necessary changes.
Thanks Again!

@sangeethababu9223
Copy link
Member

@m4olivei ,
As we discussed, I've created an issue for masthead. You or @jkaeser could look into it.
Thanks

@sangeethababu9223 sangeethababu9223 moved this from Doing to Review in Carbon for IBM.com Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangeethababu9223 sangeethababu9223

Labels
package: styles Work necessary for the Carbon for IBM.com styles package package: web components Work necessary for the IBM.com Library web components package
Projects
Carbon for IBM.com
Status: Review
Milestone
No milestone
3 participants
@m4olivei @kennylam @sangeethababu9223