Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import PSBT is not importing partial signatures #162

Open
jbrauck-unchained opened this issue Dec 13, 2024 · 1 comment
Open

Import PSBT is not importing partial signatures #162

jbrauck-unchained opened this issue Dec 13, 2024 · 1 comment
Labels
@caravan/coordinator enhancement New feature or request good first issue Good for newcomers

Comments

@jbrauck-unchained
Copy link
Contributor

Recreation steps:

  1. Craft a transaction in caravan, download unsigned PSBT.
  2. Sign transaction outside of caravan, copy partially signed PSBT
  3. Import wallet config again, go to "Send", "Import PSBT"
  4. Import the partially signed PSBT
  5. Note that the signature did not carry over

This definitely feels like a bug, let me know if I am wrong.

Unsigned PSBT

cHNidP8BAHwBAAAAAsEFicXI4HjydjPnHnQeERXIJrOakYEUt/Ic0fCNiSN+AAAAAAD/////a2EtzcyeJcYcr/4SikTPdrvNCcIaCM3zNN232jfrlNkAAAAAAP////8BEBIRAAAAAAAXqRQZeKGMQeKp8RopRKHSpilPWyhzeYcAAAAATwEENYfPBBN2KQ8AAAACbVu7qYOg/Zgx5UuIN9Q1MNawFWnbzeruGp0ynLn5rtkDT/UDSQiraRWeqaqGwld0OpC5ATt+0TwadVMQd2ucfVkU6Pvs4S0AAIABAACAAAAAgAIAAABPAQQ1h88EjMepUQAAAAGa5TgU/xdnWvwtwVzx1qK8cW9w8BbrpxAwhmX4Si3nowPfnUTx/SENNZxB6nif1Iuzk0O5JE+XJKMjtVYjjPALshTrp0AYLQAAgAEAAIAAAACAAQAAAE8BBDWHzwSjrSFyAAABv9Ze7/aOPjhZ0S7GPKPDSolzOxQpnwenDbd/FWRvzd4vAwemma5/w5iGmElsDRx4LXFy57VhpZD6ggZS45OUnxfwFO+l2RYtAACAAQAAgMgAAIC/AQAAAAEA/XoCAQAAAAK8ZFiSabp7iaoT+JCKmDFEKvk8HWFqNEZ+v6T8iwPO3wEAAAD9/QAASDBFAiEA2H3veISPA4cD4m9AKrepBk1p7xtCSa78Fek/83BTnoECICT3GbPisSB9zBpogTREnfTTt8aNcYUKB4j6q68TPImrAUcwRAIgWvguGm3UITzYqwcZoNGNTsBr6OaX/cXGp8AhVs0E9bACIAQ3Su7WIyj9NLXv5iX9o3kD5HWI/KT8fxEDt6082sbeAUxpUiEChfGT5eaCapf4SbMpIe9GY0RoOTiwvbZl8mqQT3g0urshAxWLarlpmvSVuAXImxrOkOLFk/VSzyrDgxzjtEvdHNflIQOxT5pPGjk6Lx5tJzgKAH2oy9p5lfBFGMZ5CDXFdAkZQFOu/////40vbk2ThbdeCQZt4ACFzNp5Q9MEQDgJoAdgAclrWsLpAQAAAP39AABIMEUCIQC2Z8196raYGQHfChJf09yv6iKqFz7Mb8Wewl483UAOmQIgTJuLLwzQwRKsm6sXKxZn543O/ZGQSVavikwtH4ZHlOoBRzBEAiA4saVr9sH6UoGmwiAThIltYnnGHrO6GZTfytRZjgaT5gIgabqZJjjOVashh8EeLhbqTECnQ7eLOtRtXZKP/17NzTYBTGlSIQI3Rz87e/zu3iIO/lJdl7Iok3MAYoFlzZCCg5jde5EhaiEDmKadb5+lSmLrPjnBhj0L08XFoupOMSIvlUCsCZXHYIkhA71pR/I1wYn2W4eLzpfZ0AvznQNGVGu09t/MtGQuHP0LU67/////AeTUAQAAAAAAF6kUX2Zv5R3hHPxTo5sbv1WdGtsu1VSHAAAAAAEEaVIhAnU38sN/bt9PgCkeln0letuJf8keK8uczjSV3y19wVnAIQKlDi6DJJ07NNdjn2mKX/LZXX+AArwN+Cj58knyUCQEgSEDbmAjhYdwE6myUgIxvrAHOIbVljqV1w6+Sy921oWVwcRTriIGAnU38sN/bt9PgCkeln0letuJf8keK8uczjSV3y19wVnAHOunQBgtAACAAQAAgAAAAIABAAAAAAAAAA0AAAAiBgKlDi6DJJ07NNdjn2mKX/LZXX+AArwN+Cj58knyUCQEgRzo++zhLQAAgAEAAIAAAACAAgAAAAAAAAANAAAAIgYDbmAjhYdwE6myUgIxvrAHOIbVljqV1w6+Sy921oWVwcQc76XZFi0AAIABAACAyAAAgL8BAAAAAAAADQAAAAABAP2DAQEAAAAAAQLO49NC6Hph1Jsyze8C2TGE9sGYZnfYrt12koRRuRcujgAAAAAXFgAUlOPF22EchDOavNt6As9cpxG+4r79////9fZweQyZdFnV28bYCQSgMeqWMRbzT+SmiXREmumDYusAAAAAFxYAFNua+y0WxZyyvndta0uklHbMJIUV/f///wFAQg8AAAAAABepFCqLo1MKE79Dnxqs9xPcK59IZLNLhwJIMEUCIQDmd8yj+TXDsBIfMj1naCIswtH2n1ZB3SE9Ta6mJX5qQAIgBg66OBdY7gSNwRrG2WvA2qdKkQxILy+uI8O/rSpiYyIBIQO0Az9GwbQ1WG0z4h1L8iGqlLITGmkwiF57lKUaLSafbQJHMEQCIHgbH5Xtkw57r2Ge0ZpRqyv4rqtw1pkws2piKGN3zDYkAiAO54W+s8OgHd6stEVoGe+ZRA5Tsish/vYJLWRrw4rhNwEhAhVcKLhua9a/YPYHfvvETICWaM4Vtjs+AQavpuP6bgOBAAAAAAEEaVIhAwSzj3Vs77p0tOl+OR1FQFzrD7tH1TCVw3ru0HXHGZyZIQN/NVjAivWeKk519c866JaZAJY6DMXNaOjUfSf+QewtKCEDm8saiYi21P2uqlAlUPGfM2ZBdh0y5zbta3hurbB44dhTriIGAwSzj3Vs77p0tOl+OR1FQFzrD7tH1TCVw3ru0HXHGZyZHO+l2RYtAACAAQAAgMgAAIC/AQAAAAAAAAsAAAAiBgN/NVjAivWeKk519c866JaZAJY6DMXNaOjUfSf+QewtKBzrp0AYLQAAgAEAAIAAAACAAQAAAAAAAAALAAAAIgYDm8saiYi21P2uqlAlUPGfM2ZBdh0y5zbta3hurbB44dgc6Pvs4S0AAIABAACAAAAAgAIAAAAAAAAACwAAAAAA

Partially signed PSBT

cHNidP8BAHwBAAAAAsEFicXI4HjydjPnHnQeERXIJrOakYEUt/Ic0fCNiSN+AAAAAAD/////a2EtzcyeJcYcr/4SikTPdrvNCcIaCM3zNN232jfrlNkAAAAAAP////8BEBIRAAAAAAAXqRQZeKGMQeKp8RopRKHSpilPWyhzeYcAAAAATwEEiLIeBBN2KQ8AAAACbVu7qYOg/Zgx5UuIN9Q1MNawFWnbzeruGp0ynLn5rtkDT/UDSQiraRWeqaqGwld0OpC5ATt+0TwadVMQd2ucfVkU6Pvs4S0AAIABAACAAAAAgAIAAABPAQSIsh4EjMepUQAAAAGa5TgU/xdnWvwtwVzx1qK8cW9w8BbrpxAwhmX4Si3nowPfnUTx/SENNZxB6nif1Iuzk0O5JE+XJKMjtVYjjPALshTrp0AYLQAAgAEAAIAAAACAAQAAAE8BBIiyHgSjrSFyAAABv9Ze7/aOPjhZ0S7GPKPDSolzOxQpnwenDbd/FWRvzd4vAwemma5/w5iGmElsDRx4LXFy57VhpZD6ggZS45OUnxfwFO+l2RYtAACAAQAAgMgAAIC/AQAAAAEA/XoCAQAAAAK8ZFiSabp7iaoT+JCKmDFEKvk8HWFqNEZ+v6T8iwPO3wEAAAD9/QAASDBFAiEA2H3veISPA4cD4m9AKrepBk1p7xtCSa78Fek/83BTnoECICT3GbPisSB9zBpogTREnfTTt8aNcYUKB4j6q68TPImrAUcwRAIgWvguGm3UITzYqwcZoNGNTsBr6OaX/cXGp8AhVs0E9bACIAQ3Su7WIyj9NLXv5iX9o3kD5HWI/KT8fxEDt6082sbeAUxpUiEChfGT5eaCapf4SbMpIe9GY0RoOTiwvbZl8mqQT3g0urshAxWLarlpmvSVuAXImxrOkOLFk/VSzyrDgxzjtEvdHNflIQOxT5pPGjk6Lx5tJzgKAH2oy9p5lfBFGMZ5CDXFdAkZQFOu/////40vbk2ThbdeCQZt4ACFzNp5Q9MEQDgJoAdgAclrWsLpAQAAAP39AABIMEUCIQC2Z8196raYGQHfChJf09yv6iKqFz7Mb8Wewl483UAOmQIgTJuLLwzQwRKsm6sXKxZn543O/ZGQSVavikwtH4ZHlOoBRzBEAiA4saVr9sH6UoGmwiAThIltYnnGHrO6GZTfytRZjgaT5gIgabqZJjjOVashh8EeLhbqTECnQ7eLOtRtXZKP/17NzTYBTGlSIQI3Rz87e/zu3iIO/lJdl7Iok3MAYoFlzZCCg5jde5EhaiEDmKadb5+lSmLrPjnBhj0L08XFoupOMSIvlUCsCZXHYIkhA71pR/I1wYn2W4eLzpfZ0AvznQNGVGu09t/MtGQuHP0LU67/////AeTUAQAAAAAAF6kUX2Zv5R3hHPxTo5sbv1WdGtsu1VSHAAAAACICA25gI4WHcBOpslICMb6wBziG1ZY6ldcOvksvdtaFlcHESDBFAiEAh22IiOctfB0GhnIeatJ6rqf0btBRi0Xr+Bxw62k2iBkCIDXQz2VtLBgZelZWU9tW5XAnsOsvGUM0mjB0JVguOgrWAQEEaVIhAnU38sN/bt9PgCkeln0letuJf8keK8uczjSV3y19wVnAIQKlDi6DJJ07NNdjn2mKX/LZXX+AArwN+Cj58knyUCQEgSEDbmAjhYdwE6myUgIxvrAHOIbVljqV1w6+Sy921oWVwcRTriIGAnU38sN/bt9PgCkeln0letuJf8keK8uczjSV3y19wVnAHOunQBgtAACAAQAAgAAAAIABAAAAAAAAAA0AAAAiBgKlDi6DJJ07NNdjn2mKX/LZXX+AArwN+Cj58knyUCQEgRzo++zhLQAAgAEAAIAAAACAAgAAAAAAAAANAAAAIgYDbmAjhYdwE6myUgIxvrAHOIbVljqV1w6+Sy921oWVwcQc76XZFi0AAIABAACAyAAAgL8BAAAAAAAADQAAAAABAP2DAQEAAAAAAQLO49NC6Hph1Jsyze8C2TGE9sGYZnfYrt12koRRuRcujgAAAAAXFgAUlOPF22EchDOavNt6As9cpxG+4r79////9fZweQyZdFnV28bYCQSgMeqWMRbzT+SmiXREmumDYusAAAAAFxYAFNua+y0WxZyyvndta0uklHbMJIUV/f///wFAQg8AAAAAABepFCqLo1MKE79Dnxqs9xPcK59IZLNLhwJIMEUCIQDmd8yj+TXDsBIfMj1naCIswtH2n1ZB3SE9Ta6mJX5qQAIgBg66OBdY7gSNwRrG2WvA2qdKkQxILy+uI8O/rSpiYyIBIQO0Az9GwbQ1WG0z4h1L8iGqlLITGmkwiF57lKUaLSafbQJHMEQCIHgbH5Xtkw57r2Ge0ZpRqyv4rqtw1pkws2piKGN3zDYkAiAO54W+s8OgHd6stEVoGe+ZRA5Tsish/vYJLWRrw4rhNwEhAhVcKLhua9a/YPYHfvvETICWaM4Vtjs+AQavpuP6bgOBAAAAACICAwSzj3Vs77p0tOl+OR1FQFzrD7tH1TCVw3ru0HXHGZyZRzBEAiBEv5jaVRWjyL/CEQNlWhvPk3nmhrl1w6Pkg72IBn2i2QIgQlOJduxuH2leZ3W1Kp7voouWJumr90t/HXd3fX42YLwBAQRpUiEDBLOPdWzvunS06X45HUVAXOsPu0fVMJXDeu7QdccZnJkhA381WMCK9Z4qTnX1zzrolpkAljoMxc1o6NR9J/5B7C0oIQObyxqJiLbU/a6qUCVQ8Z8zZkF2HTLnNu1reG6tsHjh2FOuIgYDBLOPdWzvunS06X45HUVAXOsPu0fVMJXDeu7QdccZnJkc76XZFi0AAIABAACAyAAAgL8BAAAAAAAACwAAACIGA381WMCK9Z4qTnX1zzrolpkAljoMxc1o6NR9J/5B7C0oHOunQBgtAACAAQAAgAAAAIABAAAAAAAAAAsAAAAiBgObyxqJiLbU/a6qUCVQ8Z8zZkF2HTLnNu1reG6tsHjh2Bzo++zhLQAAgAEAAIAAAACAAgAAAAAAAAALAAAAAAA=
@bucko13 bucko13 added enhancement New feature or request good first issue Good for newcomers @caravan/coordinator labels Dec 13, 2024
@bucko13
Copy link
Contributor

bucko13 commented Dec 13, 2024

Marking this as a feature request (aka "enhancement"). This is expected behavior though agreed it's undesirable. Would be a nice enhancement to auto parse any sigs as well. It should be pretty easy for someone new to the code base to resolve so marked it as a good first issue. I'm happy to try and help get someone started if they have specific questions for implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@caravan/coordinator enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants