Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running serversetup again should not try to setup an existing server #31

Closed
solomon23 opened this issue Aug 30, 2019 · 8 comments
Closed

Comments

@solomon23
Copy link

If you run serversetup against an existing server - it should check and not try to setup SSL again. Ref #30

@Hazzard17h
Copy link
Contributor

If you run serversetup against an existing server with root ssl and redirect (setupped from CLI), it warns with "You may have already setup the server! Use caprover login to log into an existing server.", and fails with an error.

@solomon23
Copy link
Author

In my case i ran serversetup against an existing server that I never setup with the CLI. The SSL was already setup though and it asked to set it up again.

@Hazzard17h
Copy link
Contributor

Maybe the http -> https redirect is not enabled, otherwise it should warn as I said, even if it is not setupped from the CLI.

@githubsaturn
Copy link
Collaborator

I believe there's a way for us to detect the existing installation if "force HTTPS" isn't activated. We can do so by getting the existing root domain of the installation. If the root domain is the default one, we know it's a fresh installation, otherwise it's an existing installation.

@solomon23
Copy link
Author

Maybe the http -> https redirect is not enabled, otherwise it should warn as I said, even if it is not setupped from the CLI.

Correct - I never enabled that

@Hazzard17h
Copy link
Contributor

See here
Needs to be tested @solomon23

@solomon23
Copy link
Author

solomon23 commented Sep 5, 2019

@Hazzard17h Confirmed it fixes it

@githubsaturn
Copy link
Collaborator

Fixed in #33 and released as 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants