Merge pull request #127 from cap-js/FixBugRandomNameInEntityKey

yashmeet29 · web-flow · commit 17ec645533b4 · 2025-04-24T16:08:28.000+05:30
Fix bug when Entity's primary key is not ID
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
 - Handling of special characters in attachments name during upload and rename of attachments.
 
 ### Fixed
+- Error to allow any name in the primary key for the entity.
 - Issue with deleting attachments from SDM when the entity has not been saved once.
 - Error message in case of rename when attachment is deleted from backend SDM repository.
 
diff --git a/lib/persistence/index.js b/lib/persistence/index.js
@@ -40,11 +40,9 @@ async function getFolderIdForEntity(attachments, req, repositoryId) {
 }
 
 async function updateAttachmentInDraft(req, data) {
-  const up_ = req.target.keys.up_.keys[0].$generatedFieldName;
-  const idValue = up_.split("__")[1];
   return await UPDATE(req.target)
     .set({ folderId: data.folderId, url: data.url, status: "Clean" })
-    .where({ [idValue]: req.data[idValue] });
+    .where({ ["ID"]: req.data["ID"] });
 }
 
 async function getURLsToDeleteFromAttachments(deletedAttachments, attachments) {

Original file line number	Diff line number	Diff line change
`@@ -40,11 +40,9 @@ async function getFolderIdForEntity(attachments, req, repositoryId) {`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`async function updateAttachmentInDraft(req, data) {`
`43`		`- const up_ = req.target.keys.up_.keys[0].$generatedFieldName;`
`44`		`- const idValue = up_.split("__")[1];`
`45`	`43`	`return await UPDATE(req.target)`
`46`	`44`	`.set({ folderId: data.folderId, url: data.url, status: "Clean" })`
`47`		`- .where({ [idValue]: req.data[idValue] });`
	`45`	`+ .where({ ["ID"]: req.data["ID"] });`
`48`	`46`	`}`
`49`	`47`
`50`	`48`	`async function getURLsToDeleteFromAttachments(deletedAttachments, attachments) {`