Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to set the cpu_over_commit_ratio parameter when adding KVM pod. #265

Open
SpirosStyliaras opened this issue Nov 29, 2021 · 1 comment
Labels

Comments

@SpirosStyliaras
Copy link

SpirosStyliaras commented Nov 29, 2021

Hi,
The method make_payloads in the module maas.client.utils.multipart contains a bug I guess. We can not set value to cpu_over_commit_ratio parameter of Pod class. This parameter is supposed to be set with float value. When I try to create
a KVM virsh pod I get the following error:
AssertionError: 'cpu_over_commit_ratio' is unrecognised: <float value>

I guess we have to add the following elif condition in the make_payloads function:
elif isinstance(content, float): yield make_bytes_payload(name, b"%f" % content)

Copy link

github-actions bot commented Feb 2, 2024

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant