Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer and subordinate relation types #18

Closed
PietroPasotti opened this issue Mar 29, 2023 · 1 comment
Closed

peer and subordinate relation types #18

PietroPasotti opened this issue Mar 29, 2023 · 1 comment

Comments

@PietroPasotti
Copy link
Collaborator

At the moment it is possible to model peer and subordinate relations using state.Relation, but it's not quite wieldy.
We should consider adding PeerRelation and SubordinateRelation types that offer more sensible defaults or hide certain arguments that don't make sense in that context.

PeerRelation:

  • remote_app_name should be the same application name as the unit being tested
  • remote_app_data should point to local_app_data or disappear
  • in general naming of 'remote' is dubious in a peer-relation context

SubordinateRelation:

  • instead of 'remote', should we be talking of 'primary'?
  • there is always exactly one 'remote unit'.

mix cleanup:

  • remove Relation.leader_id
@PietroPasotti
Copy link
Collaborator Author

closed in #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant