Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project is not setting 100% coverage #92

Open
gabrielcocenza opened this issue Aug 21, 2024 · 0 comments · May be fixed by #142
Open

Project is not setting 100% coverage #92

gabrielcocenza opened this issue Aug 21, 2024 · 0 comments · May be fixed by #142

Comments

@gabrielcocenza
Copy link
Member

This project doesn't set the tool coverage to 100% which can decrease the code quality.

Right now the project is at 66% coverage

unit run-test: commands[1] | coverage report
Name             Stmts   Miss  Cover   Missing
----------------------------------------------
src/charm.py        99     35    65%   72, 97-124, 131-136, 151-155, 175-177, 199-201, 213, 217-237
src/service.py      69     22    68%   23, 36-38, 42, 47-51, 121-131, 139-143
----------------------------------------------
TOTAL              168     57    66%
Coverage failure: total of 66 is less than fail-under=100

We need to reach to 100% and then change the configuration on pyproject.toml. Would also be nice to have a standard pyproject file into soleng automation to force new projects

@H-M-Quang-Ngo H-M-Quang-Ngo linked a pull request Mar 14, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant