[DPE-5830] Bump to 24.04 #495
Open
+623
−547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmraul
force-pushed
the
bump_to_24_04
branch
from
4894dd5 to
1445650
Compare
reneradoi
commented
Dec 12, 2024
| @@ -79,7 +79,7 @@ def __init__( | |||
| self.peer_relation = peer_relation | |||
| self.jdk_path = jdk_path | |||
| self.certs_path = certs_path | |||
| self.keytool = self.jdk_path + "/bin/keytool" | |||
| self.keytool = "opensearch.keytool" | |||
There was a problem hiding this comment.
I like that change and that this is now provided by the snap!
| @@ -114,10 +114,11 @@ jobs: | |||
| path: | |||
| - . | |||
| - ./tests/integration/relations/opensearch_provider/application-charm/ | |||
| uses: canonical/data-platform-workflows/.github/workflows/build_charm.yaml@v22.0.0 | |||
| uses: canonical/data-platform-workflows/.github/workflows/build_charm.yaml@beta-charmcraftst124 | |||
There was a problem hiding this comment.
Maybe add some # todo comments here?
Comment on lines
+550
to
+552
| with tempfile.NamedTemporaryFile( | ||
| mode="w+t", dir=self.charm.opensearch.paths.conf | ||
| ) as ca_tmp_file: |
There was a problem hiding this comment.
👍 good change. Just for consideration: there is also a self.charm.opensearch.paths.certs.
| # should not be updated unless https://github.com/juju/python-libjuju/issues/1093 is fixed | ||
| juju = "==3.5.0" | ||
| # websockets issue solved from 3.2.5.1 https://github.com/juju/python-libjuju/issues/1184 # TODO: restore to 3.5.0 |
There was a problem hiding this comment.
Nice to see this fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be added