generated from canonical/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-4859] Make cloud-init optional #398
Open
phvalguima
wants to merge
14
commits into
main
Choose a base branch
from
DPE-4859-remove-cloud-init-mandatory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, cloud-init was mandatory to be set in order for OpenSearch to work. This PR updates the README and integration tests to remove this dependency, following recent charm changes. Closes #359
reneradoi
previously approved these changes
Aug 16, 2024
delgod
previously approved these changes
Aug 16, 2024
Mehdi-Bendriss
previously approved these changes
Sep 4, 2024
izmalk
reviewed
Sep 4, 2024
Co-authored-by: Vladimir Izmalkov <[email protected]>
phvalguima
dismissed stale reviews from Mehdi-Bendriss, delgod, and reneradoi
via
September 4, 2024 14:14
25f963f
Co-authored-by: Vladimir Izmalkov <[email protected]>
Co-authored-by: Vladimir Izmalkov <[email protected]>
Co-authored-by: Vladimir Izmalkov <[email protected]>
Co-authored-by: Vladimir Izmalkov <[email protected]>
Co-authored-by: Vladimir Izmalkov <[email protected]>
Co-authored-by: Vladimir Izmalkov <[email protected]>
Co-authored-by: Vladimir Izmalkov <[email protected]>
izmalk
approved these changes
Sep 4, 2024
juditnovak
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, cloud-init was mandatory to be set in order for OpenSearch to work. This PR updates the README and integration tests to remove this dependency, following recent charm changes.
Closes #359