CLI: Rework cmpInstanceKeys for contextual completions based on instance type
#14684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadinsayani
changed the title
lxc storage volume completion fixes and description updateslxc storage volume completion fixes and description updates
kadinsayani
force-pushed
the
14682-storage-volume-completion
branch
from
1c67d9f to
2f53f43
Compare
kadinsayani
changed the title
lxc storage volume completion fixes and description updateslxc storage volume completion fixes and command description updates
kadinsayani
force-pushed
the
14682-storage-volume-completion
branch
from
2f53f43 to
14d9643
Compare
kadinsayani
changed the title
lxc storage volume completion fixes and command description updates
kadinsayani
force-pushed
the
14682-storage-volume-completion
branch
3 times, most recently
from
463ac01 to
33c5c93
Compare
simondeziel
reviewed
Dec 18, 2024
kadinsayani
force-pushed
the
14682-storage-volume-completion
branch
2 times, most recently
from
9a7d059 to
5495fc8
Compare
tomponline
reviewed
Dec 19, 2024
|
Is it possible to split this pr into two, so we can merge the non contentious parts? |
kadinsayani
force-pushed
the
14682-storage-volume-completion
branch
2 times, most recently
from
4307f76 to
fb65418
Compare
kadinsayani
changed the title
kadinsayani
changed the title
cmpInstanceKeys for contextual completions based on instance type
kadinsayani
force-pushed
the
14682-storage-volume-completion
branch
from
fb65418 to
34b3579
Compare
simondeziel
reviewed
Jan 17, 2025
This commit adds contextual completions for instance config keys based on instance type. Signed-off-by: Kadin Sayani <[email protected]>
kadinsayani
force-pushed
the
14682-storage-volume-completion
branch
from
34b3579 to
50b3454
Compare
kadinsayani
force-pushed
the
14682-storage-volume-completion
branch
from
50b3454 to
2da14fd
Compare
…Split` in storage pool volume completion functions Signed-off-by: Kadin Sayani <[email protected]>
kadinsayani
force-pushed
the
14682-storage-volume-completion
branch
from
2da14fd to
f4dc670
Compare
simondeziel
approved these changes
Jan 17, 2025
tomponline
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14689.
Summary of changes: