Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository class growing too complex #175

Open
deusebio opened this issue Jun 13, 2023 · 0 comments
Open

Repository class growing too complex #175

deusebio opened this issue Jun 13, 2023 · 0 comments

Comments

@deusebio
Copy link
Collaborator

While developing I started to face a couple of warnings, linting errors related to the fact that the Repository class is growing too big. In particular:

  • We are very close to having 20 public methods, which is the limit
  • The test file is becoming larger than 1000 lines (to resolve this issue I have now temporarily disabled this lint the C0302 check)

We should identify a sensible choice for splitting the class, possibly either by function (tag, pull_request, branch_ops) or by resource (differentiating the functions that pertain to the local repo vs the one for the remote one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant