Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dss commands can affect any Deployment in the DSS_NAMESPACE #84

Open
NohaIhab opened this issue Apr 22, 2024 · 1 comment
Open

dss commands can affect any Deployment in the DSS_NAMESPACE #84

NohaIhab opened this issue Apr 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@NohaIhab
Copy link
Contributor

NohaIhab commented Apr 22, 2024

Bug Description

Some implemented dss commands can affect any Deployment in the DSS_NAMESPACE, not just Notebook deployments.
The list of these commands are:

  • dss stop
  • dss start
  • dss logs (it might be okay that logs can be run with other deployments, but it can be confusing to users so we should revise and discuss that behavior)

came up in this comment

To Reproduce

pip install -e .
KUBECONFIG=~/.kube/config
dss initialize --kubeconfig $KUBECONFIG
dss stop mlflow --kubeconfig $KUBECONFIG
dss start mlflow --kubeconfig $KUBECONFIG
dss logs mlflow --kubeconfig $KUBECONFIG

these commands succeed, where the output should rather be:

Failed to [retrieve logs/stop notebook/ start notebook]. Notebook 'mlflow' does not exist.
Run 'dss list' to check all notebooks.

Environment

microk8s 1.28/stable

@NohaIhab NohaIhab added the bug Something isn't working label Apr 22, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5597.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant