Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create should override existing service #81

Open
misohu opened this issue Apr 19, 2024 · 1 comment
Open

create should override existing service #81

misohu opened this issue Apr 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@misohu
Copy link
Member

misohu commented Apr 19, 2024

Why it needs to get done

This change is affecting edge case:

When user is trying to create a notebook wile the service with the same name exists the dss will not allow that. Steps to reproduce.

pip install .
export DSS_KUBECONFIG=~/.kube/config  # assuming config is set
dss initialize 
kubectl create service clusterip empty-service --tcp=80:9376 -n dss
dss create empty-service --image=pytorch

output:

2024-04-19 11:55:53 [INFO] [main] [create_notebook_command]: Executing create command
2024-04-19 11:55:53 [ERROR] [create_notebook] [create_notebook]: Failed to create Notebook. Notebook with name 'empty-service' already exists.
Please specify a different name.
2024-04-19 11:55:53 [ERROR] [utils] [get_service_url]: Failed to get the URL of notebook name with error code 404.
Check the debug logs for more details.
2024-04-19 11:55:53 [DEBUG] [utils] [get_service_url]: Failed to get the URL of notebook name with error: services "name" not found

Instead of the existing behavior the dss create should override existing service.

What needs to get done

dss create can create notebooks in dss namespace even if services with the same name already exist. These services will be overridden.

When is the task considered done

Functionality is implemented and tested.

@misohu misohu added the enhancement New feature or request label Apr 19, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5586.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant