Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: application plugins #628

Merged
merged 23 commits into from
Feb 3, 2025
Merged

feat: application plugins #628

merged 23 commits into from
Feb 3, 2025

Conversation

mattculler
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?
  • Have you added an entry to the changelog (docs/reference/changelog.rst)?

Allow applications to register plugins to modify library behavior.

(CRAFT-4018)

@mattculler mattculler linked an issue Jan 30, 2025 that may be closed by this pull request
application-defined plugins for craft-application #617
Closed
dariuszd21
dariuszd21 reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can work and just put some suggestions in a comments.
Thank you!

@mattculler mattculler marked this pull request as ready for review January 30, 2025 23:13
@mattculler mattculler force-pushed the work/CRAFT-4018-application-plugins branch from 1a134b5 to 3583247 Compare January 31, 2025 01:52
@mattculler
Copy link
Contributor Author

If you guys have ideas about how to put together an integration test I'm all ears. Ideally it would involve a toy application with its own pyproject.toml, so we could see a plugin actually loaded from that file. But, I'm not sure how to make that happen - perhaps our actual integration will have to serve as the test.

dariuszd21
dariuszd21 reviewed Jan 31, 2025
View reviewed changes
dariuszd21
dariuszd21 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

lengau
lengau approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mattculler mattculler merged commit 4689bb1 into main Feb 3, 2025
10 checks passed
@mattculler mattculler deleted the work/CRAFT-4018-application-plugins branch February 3, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@dariuszd21 dariuszd21 dariuszd21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

application-defined plugins for craft-application
3 participants
@mattculler @lengau @dariuszd21