dynamic service registration

[dariuszd21]

What needs to get done

Add an API that allows to create dynamically ServiceFactory from the given sequence or extend the existing one to be able to create services on demand,

Why it needs to get done

We want to be able to register additional services dynamically through the API, without relying on inheritance.

To be able to do dynamically define a ServiceFactory extended with all the services provided by our application / library.

We should be able to create a factory dynamically by just specifying additional services that should be included without an inheritance dance.

import craft_lib
import craft_application

additional_services = craft_lib.get_services()
service_factory = craft_application.ServiceFactory.with_additional_services(additional_services)

[syncronize-issues-to-jira]

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3738.

This message was autogenerated

[lengau]

I'd rather give the ServiceFactory a register classmethod that lets you register different services to the factory.

[dariuszd21]

I'd rather give the ServiceFactory a register classmethod that lets you register different services to the factory.

That's why it's a spike as I think that the final implementation will be much different than an example 😅

[lengau]

In fact thinking more about it, I think the ServiceFactory could even drop the entire concept of "native" services and use register for everything. That'd be a breaking change that we don't need to do now, but the registration should allow it to happen.

We might even be able to use this to help with lazy loading of service modules. E.g. if you were to register the services like:

craft_application.ServiceFactory.register("provider", "snapcraft.services.provider.Provider")

then snapcraft.services.provider only needs to be imported when we load the provider service (meaning that craft-providers and its dependencies only need to be imported when we load the provider service).

[dariuszd21]

In fact thinking more about it, I think the ServiceFactory could even drop the entire concept of "native" services and use register for everything. That'd be a breaking change that we don't need to do now, but the registration should allow it to happen.

We might even be able to use this to help with lazy loading of service modules. E.g. if you were to register the services like:

craft_application.ServiceFactory.register("provider", "snapcraft.services.provider.Provider")

then snapcraft.services.provider only needs to be imported when we load the provider service (meaning that craft-providers and its dependencies only need to be imported when we load the provider service).

I'm all for the register approach replacing inheritance. I can't wait to see the prototype 😄