Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disagreement between wiki and actual usage for ascatSnpPanelMerge #93

Open
cboursnell opened this issue Jun 16, 2020 · 2 comments
Open

Comments

@cboursnell
Copy link

On the wiki https://github.com/cancerit/ascatNgs/wiki/Reference-files-from-normal-sample-data it says you can run ascatSnpPanelMerge like this:

ascatSnpPanelMerge.pl genome.fa sampleA-hets.tsv.0 [sampleB-hets.tsv.0] > SnpPositions.tsv

where you increment the names of the samples, but keep the .0 as the suffix. When trying this I got the error from the script saying Can't use an undefined value as an ARRAY reference at /opt/wtsi-cgp/bin/ascatSnpPanelMerge.pl line 55.

If I rename my inputs to sample.tsv.0, sample.tsv.1 ... etc then the script runs fine and produces expected output. The method described in the wiki seems better to me.

@rulixxx
Copy link
Contributor

rulixxx commented Jun 16, 2020

Hi Chris!

Have been recently using this piece of code myself. I think that you got it correctly the first time. One increments the sample names but keeps the numeric suffix constant.

Looking trough the code it seems that the suffix is one based and not zero based as the wiki seems to suggest. I think that is what is causing your error

@panxiaoguang
Copy link

how many memories you use for the scripts? only one file need more than 200G?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants