-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ADM and mappings to include new ICDC Sample properties #6
Comments
sample_chronology is also new: https://github.com/CBIIT/icdc-model-tool/blob/master/model-desc/icdc-model-props.yml#L814
|
From Mark Jensen via Slack:
|
@mbrush can you update this issue with any additional information? assuming the ADM will not continue to be updated, we should likely at least represent these mappings in the CDM. Is this something that can be incorporated now or do these require additional review? |
I agree that the ADM will not be maintained. Was a great way to get started, but now that we have a model we can add mappings to new properties of included nodes or properties from entirely new nodes, to the CRDCH spreadsheet mapping columns. Let's take a look at these in our next call and close out this ticket? Also, this ticket raises the general concern about keeping up to date with changes / additions to source models. We had assigned folks to set up a workflow for this, but it was never prioritized and I think Mara was the main driver here and she is no longer on the project. We should probably revisit and prioritize this after our round of October presentations. |
See the four new properties added by PR here:
CBIIT/icdc-model-tool#49
The text was updated successfully, but these errors were encountered: