Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow video track playing if audio codec is not supported #1602

Open
JaroslavHerber opened this issue Dec 12, 2024 · 3 comments
Open

Allow video track playing if audio codec is not supported #1602

JaroslavHerber opened this issue Dec 12, 2024 · 3 comments

Comments

@JaroslavHerber
Copy link

Currently, the player throws an exception, if an audio codec is not supported:
MediaError: MANIFEST_INCOMPATIBLE_CODECS_ERROR: No supported audio adaptations

But the player might still play the videotrack, if supported. For example DashJS plays the videotrack - here is an example:
https://dash.akamaized.net/dash264/TestCasesDolby/2/Living_Room_1080p_20_96k_2997fps.mpd

@peaBerberian
Copy link
Collaborator

peaBerberian commented Dec 16, 2024

Hi @JaroslavHerber,

This was done in purpose in our case because we assumed that people would want at least one playable video and audio tracks when there are some of them in the MPD (if the MPD has no audio AdaptationSet, we will play).

You would prefer just playing with no audio?
I guess we could add an option but I do not see the real use for this.

@JaroslavHerber
Copy link
Author

I think a half cake is better than no cake :)
Making this configurable would be a plus point - maybe not directly for consumers, but for developers. Like a growth hack.

@peaBerberian
Copy link
Collaborator

We've discussed about that today and we're OK with adding options for that.

For now we're planning for two options, one for audio the other for video, where the idea would be to continue without that type of content if either none of its codecs are supported or if none of it is decipherable.

Exact details on the implementation and the option's name will be decided on as we work on it, we should hopefully begin working on it in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants