Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Basic authentication support is missing #165

Closed
barmac opened this issue May 23, 2024 · 3 comments
Closed

HTTP Basic authentication support is missing #165

barmac opened this issue May 23, 2024 · 3 comments
Assignees
@jwulf

Comments

@barmac
Copy link

barmac commented May 23, 2024 •
edited
Loading

SDK Component

Camunda 8 client

Expected Behavior

Allow to pass username and password to authenticate with HTTP Basic.

Current Behavior

Support is missing although it is provided in zeebe-node: https://github.com/camunda-community-hub/zeebe-client-node-js/?tab=readme-ov-file#basic-auth

Possible Solution

Port from zeebe-node

Steps to Reproduce

Context (Environment)

Required for camunda/camunda-modeler#4233
@barmac barmac mentioned this issue May 23, 2024
Draft
@jwulf
Copy link
Member

jwulf commented May 23, 2024

Can do. I pulled this out of the gRPC client rather than adding it across the board. Sorry! I added for my personal use case, and I didn't realise anyone else was using it.

@jwulf jwulf self-assigned this May 23, 2024
jwulf added a commit that referenced this issue May 24, 2024
@jwulf
feat(camunda8): support Basic Auth
1457277 
Implement Basic Auth provider for all clients

fixes #165
@jwulf jwulf mentioned this issue May 24, 2024
Merged
@jwulf jwulf closed this as completed in d6acdfd May 24, 2024
@github-project-automation github-project-automation bot moved this from 🆕 Inbox to ✅ Done in Developer Experience May 24, 2024
github-actions bot pushed a commit that referenced this issue May 24, 2024
@semantic-release-bot
chore(release): 8.5.4 [skip ci]
18d53f6 
## [8.5.4](v8.5.3...v8.5.4) (2024-05-24)

### Bug Fixes

* **issue137:** support ZEEBE_REST_ADDRESS and ZEEBE_GRPC_ADDRESS environment variables ([#159](#159)) ([41fdca0](41fdca0))
* **oauth:** correctly expire cached token ([#164](#164)) ([c86e550](c86e550)), closes [#163](#163)

### Features

* **camunda8:** support Basic Auth ([d6acdfd](d6acdfd)), closes [#165](#165)
* **oauth:** add conditional loading of client key and cert for getting a token ([#161](#161)) ([f05aa8a](f05aa8a))
* **zeebe:** support Zeebe User Task REST API ([022607b](022607b)), closes [#34](#34)
github-actions bot pushed a commit that referenced this issue May 24, 2024
@semantic-release-bot
chore(release): 8.5.4 [skip ci]
570d5bb 
## [8.5.4](v8.5.3...v8.5.4) (2024-05-24)

### Bug Fixes

* **issue137:** support ZEEBE_REST_ADDRESS and ZEEBE_GRPC_ADDRESS environment variables ([#159](#159)) ([41fdca0](41fdca0))
* **oauth:** correctly expire cached token ([#164](#164)) ([c86e550](c86e550)), closes [#163](#163)

### Features

* **camunda8:** support Basic Auth ([d6acdfd](d6acdfd)), closes [#165](#165)
* **oauth:** add conditional loading of client key and cert for getting a token ([#161](#161)) ([f05aa8a](f05aa8a))
* **zeebe:** support Zeebe User Task REST API ([022607b](022607b)), closes [#34](#34)
@jwulf
Copy link
Member

jwulf commented May 24, 2024

Set the following via properties or env vars:

CAMUNDA_AUTH_STRATEGY=BASIC
CAMUNDA_BASIC_AUTH_USERNAME=....
CAMUNDA_BASIC_AUTH_PASSWORD=....

@barmac
Copy link
Author

barmac commented May 24, 2024

Thanks for fixing this so fast! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwulf jwulf

Labels
None yet
Projects
Developer Experience
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwulf @barmac