Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve classification of external symbols #10

Open
RaoulHC opened this issue Feb 2, 2023 · 0 comments
Open

Improve classification of external symbols #10

RaoulHC opened this issue Feb 2, 2023 · 0 comments

Comments

@RaoulHC
Copy link
Collaborator

RaoulHC commented Feb 2, 2023

Currently SExternal is a constructor in the symbol table, but it's not actually constructed anywhere even though it's checked for in the constant propagation and type checking. We should try and catch any external statements and make sure the SymbolTableEntry is updated to use SExternal.

For functions it might be worth catching any function calls to a symbol, and then updating the entry accordingly, and for subroutines we'll want to update the to extType to Maybe Type so we can catch them too. They're currently not in the SymbolTable at all, but they are symbols and that can be useful information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant