Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve types for prefetchScript and loadScript #494

Closed
troZee opened this issue Jan 31, 2024 · 7 comments · Fixed by #641
Closed

Improve types for prefetchScript and loadScript #494

troZee opened this issue Jan 31, 2024 · 7 comments · Fixed by #641
Labels
area:native The issue involves the native module of Re.Pack area:repack The issue is about logic/code inside of Re.Pack. help wanted especially welcoming for external contributions Stale type:feature Proposal or idea for a new feature or enhancement.

Comments

@troZee
Copy link
Member

troZee commented Jan 31, 2024

Here you can find a typescript spec used by react-native-codegen: https://github.com/callstack/repack/pull/495/files#diff-a063c248295c855435089dd4f53efe44eb82c9b2a8b70470fb638ce5d3d037e4R4

In this spec, we use Object which is not meaningful for the developer. Please go to the native implementation here

fun loadScript(scriptId: String, configMap: ReadableMap, promise: Promise) {
and replace all Objects with the appropriate type.

Originally posted by @troZee in #344 (comment)

@jbroma
Copy link
Member

jbroma commented Feb 21, 2024

@troZee please update the description 🙏 thanks!

@troZee
Copy link
Member Author

troZee commented Feb 22, 2024

@jbroma done

@jbroma jbroma added type:feature Proposal or idea for a new feature or enhancement. area:repack The issue is about logic/code inside of Re.Pack. area:native The issue involves the native module of Re.Pack labels Feb 22, 2024
@jbroma jbroma changed the title Fix types for prefetch and loadScript Improve types for prefetchScript and loadScript Feb 22, 2024
@jbroma jbroma added the help wanted especially welcoming for external contributions label Feb 23, 2024
Copy link

This issue has been marked as stale because it has been inactive for 30 days. Please update this issue or it will be automatically closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 25, 2024
@jbroma jbroma removed the Stale label Apr 2, 2024
Copy link

github-actions bot commented May 3, 2024

This issue has been marked as stale because it has been inactive for 30 days. Please update this issue or it will be automatically closed in 14 days.

@github-actions github-actions bot added the Stale label May 3, 2024
Copy link

This issue has been automatically closed because it has been inactive for more than 14 days. Please reopen if you want to add more context.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
@jbroma jbroma removed the Stale label May 17, 2024
@jbroma jbroma reopened this May 17, 2024
@jbroma jbroma mentioned this issue Jun 9, 2024
2 tasks
Copy link

This issue has been marked as stale because it has been inactive for 30 days. Please update this issue or it will be automatically closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 17, 2024
Copy link

github-actions bot commented Jul 1, 2024

This issue has been automatically closed because it has been inactive for more than 14 days. Please reopen if you want to add more context.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:native The issue involves the native module of Re.Pack area:repack The issue is about logic/code inside of Re.Pack. help wanted especially welcoming for external contributions Stale type:feature Proposal or idea for a new feature or enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants