Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starlark-go supports json.encode/decode, but python-starlark-go does not. #192

Open
torbsorb opened this issue May 4, 2023 · 1 comment

Comments

@torbsorb
Copy link

torbsorb commented May 4, 2023

Starlark code:

as_json = json.encode('{"key1": 1, "key2": 2}')
print(as_json)

When you run this with starlark_go it works as expected. It prints:

{"key1": 1, "key2": 2}

However, if you do the same with python-starlark-go, then you get

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
starlark_go.errors.ResolveError: <expr>:1:11: undefined: json

Minimal reproducer in Python:

from starlark_go import Starlark

s = Starlark()
s.exec('''as_json = json.encode('{"key1": 1, "key2": 2}')''')
s.eval("as_json")
@jordemort
Copy link
Contributor

Thanks for the report! I plan to add this in a future release, but I still haven't decided how I want to implement imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants