-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bake migration snapshot should not allow reserved words #693
Comments
Is this really a problem we should fix or prevent from happening? Naming things is hard and if a developer really thinks naming anything just Apart from that, I wouldn't try to gather all possible reserved keywords beforehand. Anything beyond that can be added any time. Pre- or Suffixing is possible way. Personally, I would prefer suffixing, as the name is more important than the added filler word. Alternatively, it could just check the list and request the name choice with a link to https://www.php.net/manual/en/reserved.php. |
Wouldn't a all time |
This is a (multiple allowed):
When trying to generate it, it throws this at the end
I guess it is mainly about this list? https://www.php.net/manual/en/reserved.php
If someone can help to gather the list of all possible words, I can whip up a PR addressing the issue.
My approach would be to ask() the user about a possible prefix in this case to avoid the collision (prefix defaulting to "Migration"), or allow aborting.
If continue, it would then use e.g. "MigrationNew" and that would be fine.
The text was updated successfully, but these errors were encountered: