-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin generation shouldn't include composer.json & phpunit.xml by default #998
Comments
The Alternative would be to add --vendor to put it into a vendor folder directly and adding those files. And otherwise skip them. |
Wit the addition of cakephp/plugin-installer#64 the composer.json is NOT only needed for publishing the plugin on packagist but it instead moves the autoload namespace to the plugin itself. Therefore removing it from the default template is not needed anymore.
|
No it doesn't. That change is related to composer config of the app, it has nothing to do with the composer.json within the plugin itself. So generating composer.json is still redundant for in-app plugins. |
I thought you used the namespaces configured inside those composer.json but looking at that PR again it indeed just uses the folder name inside With that I can agree, that the composer.json is actually doing nothing out of the box. As long as that plugin name doesn't colide with another vendor namespace this seems fine by me, but it would still be a bit more configurable to actually define the plugin namesapce inside the composer.json of th plugin. |
This allows generating standalone plugins in paths outside the app. By default in-app generated plugins no longer have unneeded files like composer.json etc. Closes #998
Description
The default behavior of
bake plugin
is to create an application plugin. However,plugin bake
also generatesphpunit.xml.dist
andcomposer.json
which are redundant for in-app plugins.Adding a
--standalone
option tobake plugin
would allow us to skip generating composer+phpunit configuration for in-app plugins but retain that behavior for standalone plugins.Related to #991
The text was updated successfully, but these errors were encountered: